Merge pull request #1895 from jpeterson976/issue/1654-xml-empty-style…

…-tags-prevent-saving Allow empty XML style tags when saving
ucfopen · Aug 16, 2021 · ee3b0b6 · ee3b0b6
2 parents 610e77b + 372c4ae
commit ee3b0b6
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/packages/app/obojobo-document-xml-parser/__tests__/src/text-group-parser.test.js b/packages/app/obojobo-document-xml-parser/__tests__/src/text-group-parser.test.js
@@ -145,4 +145,17 @@ describe('TextGroup parser', () => {
 
 		expect(parsed[0].text.value).toBe('')
 	})
+
+	test('Handles missing text item', () => {
+		setTextGroupElements([
+			{
+				name: 'sup',
+				value: undefined
+			}
+		])
+
+		const parsed = textGroupParser(textGroup)
+
+		expect(parsed[0].text.value).toBe('')
+	})
 })
diff --git a/packages/app/obojobo-document-xml-parser/src/text-group-parser.js b/packages/app/obojobo-document-xml-parser/src/text-group-parser.js
@@ -81,6 +81,7 @@ const parseText = (node, textItem) => {
 
 	textItem.styleList.push(styleRange)
 
+	if (!node.value) node.value = ''
 	for (const value of node.value) {
 		parseText(value, textItem)
 	}