Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix widget footer margins #1490

Conversation

cayb0rg
Copy link
Contributor

@cayb0rg cayb0rg commented Aug 16, 2023

Prevents widget footer from centering itself in the page.

@clpetersonucf
Copy link
Member

This works, but I'd actually prefer to add margin: 0 auto; to the section.widget .center selector in the same file. Currently, the fix causes the player to left-align to the available space, while the alternative would center-align the player and footer together (but we should still test the player in various embed environments to make sure it displays properly).

@cayb0rg
Copy link
Contributor Author

cayb0rg commented Aug 16, 2023

True. I considered that as well and thought being left-aligned looked more congruent with WebCourses, especially on wide screen sizes. If the author wanted to center one embedded in a page, they could use WebCourses' text centering option (or add style = "text-align: center;" if it's outside WebCourses). However, I'm totally open to making it centered by default since this centering option is not available for LTI embedded widgets, and there are ways of making it left-aligned again in pages if they wanted it to be.

Centering also does look better when opened in new tab.

@clpetersonucf clpetersonucf merged commit 9736798 into ucfopen:issue/support-dashboard-in-react Aug 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants