-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catalog accessibility indicator updates #1487
Catalog accessibility indicator updates #1487
Conversation
Widget detail page looks good, accessibility filters work great. Just needs some mobile optimization: the pseudo-elements for Features and Accessibility get overlapped on screen widths < 960px, and accessibility filter completely disappears on screen widths < 720px. |
Updated filter display for responsive screen widths. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good and functions well, I can only think of two pretty minor things that could maybe be improved:
- The ARIA labels for the toggles aren't very descriptive, something like 'display filter options by feature' when toggling on or 'hide filter options by feature' when toggling off etc. would probably do. Or potentially a more verbose instructive label since there isn't much in the way of explaining how to use the filters.
- Likewise the filter options themselves could probably use a more descriptive label so it's more immediately clear what they do.
- The filter options are all reachable in the tab order whether they've been toggled or not.
I wouldn't hold up the initial release of these features for either of these unless they're super quick fixes, though.
Improved filter accessibility based on feedback. Merging. |
f950675
into
ucfopen:issue/support-dashboard-in-react
accessibility_description
meta_data
field to provide additional context about a widget's accessibility status. The indicators are no longer displayed if a widget does not provide accessibility information; the description will simply note that accessibility data is not available.