-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/react unit tests - Part 1 #1452
Merged
clpetersonucf
merged 29 commits into
ucfopen:issue/support-dashboard-in-react
from
cayb0rg:issue/react-unit-tests
Aug 23, 2023
Merged
Issue/react unit tests - Part 1 #1452
clpetersonucf
merged 29 commits into
ucfopen:issue/support-dashboard-in-react
from
cayb0rg:issue/react-unit-tests
Aug 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/Materia into issue/react-cay
…or widget admin page
…ayer component with widgetURL param, fixes a widget creator race issue
…d out and attempts to save
clpetersonucf
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a LOT here but as best I can tell, it looks good, and the tests all pass. Great work.
clpetersonucf
merged commit Aug 23, 2023
fd51500
into
ucfopen:issue/support-dashboard-in-react
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This adds the dependency package "jest-environment-dom" to package.json.
Run
rm -rf node_modules && yarn install
to updateReact Unit Tests Part One
This PR only covers the following tests:
To run, use the command:
yarn test widget-player.test.js widget-creator.test.js support-page.test.js widget-admin-page.test.js
Running
yarn test
will include tests from the old dashboard as well as tests that have not been implemented (such as the collaborator and settings dialog).Issues fixed
Widget Admin
Widget Creator
Support / Admin Pages
Collaborate Dialog
Other Issues Fixed
History
This was originally #1402. However, since that PR, the creator and player race issues have been solved. I pulled the unit tests from that PR and updated them to account for new changes.
Pages to do in future parts