Add special brightness mode to Pixel Viewer #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mode is accessed with parameters
?mode=brightness&colour-code=brightness. It cannot be accessed in any other way?mode=brightnesssets the pixels to greyscale, sets the description and doesn't add the thresholder.?colour-code=brightnessonly activates if mode==brightness.It sets the values displayed to be the R component of the colour (it's greyscale so this is fine), and it hides the colour format radio buttons as well as the config selector.
Optionally
&picturepickercan be added to include the extra default pictures