Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax types #780

Merged
merged 1 commit into from
Apr 20, 2023
Merged

relax types #780

merged 1 commit into from
Apr 20, 2023

Conversation

bdngo
Copy link
Contributor

@bdngo bdngo commented Apr 20, 2023

This PR relaxes types for some constraints that have multiple value types.

Related PRs / Issues

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • Change to core Hammer
  • Change to a Hammer plugin
  • Other

Contributor Checklist:

  • Did you set master as the base branch?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you update the poetry.lock file if you updated the requirements in pyproject.toml?
  • (If applicable) Did you add a unit test demonstrating the PR?
  • (If applicable) Did you run this through the e2e integration tests?
  • (If applicable) Did you update the submodules in e2e/ if this feature depends on updated plugins?

@harrisonliew harrisonliew added this pull request to the merge queue Apr 20, 2023
Merged via the queue into master with commit beab9f7 Apr 20, 2023
@harrisonliew harrisonliew deleted the more-type-fixes branch April 20, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants