Updating argo-wrapper dependencies #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianj7
reviewed
Oct 31, 2024
tianj7
previously approved these changes
Oct 31, 2024
pieterlukasse
previously approved these changes
Nov 4, 2024
tianj7
reviewed
Nov 5, 2024
| @@ -405,7 +418,7 @@ def get_workflows_for_team_project(self, team_project: str) -> List[Dict]: | |||
| workflows = self.get_workflows_for_label_selector(label_selector=label_selector) | |||
| return workflows | |||
|
|
|||
| def get_workflows_for_user(self, auth_header: str) -> List[Dict]: | |||
| def get_workflows_for_user(self, auth_header: Optional[str]) -> List[Dict]: | |||
There was a problem hiding this comment.
Suggested change
| def get_workflows_for_user(self, auth_header: Optional[str]) -> List[Dict]: | |
| def get_workflows_for_user(self, auth_header: str) -> List[Dict]: |
I don't think auth_header is optional here, and probably also not optional in most other places where it is now marked as optional.
There was a problem hiding this comment.
It's because of this, the get can return None, so it expects it to be Optional:
auth_header=request.headers.get("Authorization"),
In short, we need better type annotations.
Co-authored-by: pieterlukasse <[email protected]>
pieterlukasse
previously approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket if there is one: VADC-1508
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes