Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created org.gnome.Snapshot Link Targetting the camera-app icon. #4159

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

ochi12
Copy link
Contributor

@ochi12 ochi12 commented Nov 10, 2024

Ubuntu replaced cheese in favor of gnome-snapshot since 24.04.

FROM

image

TO

image

…p to supliment missing yaru icon for gnome-snapshot
@Feichtmeier
Copy link
Member

I think this is a good change but let the others have a look, too!

Copy link
Member

@Muqtxdir Muqtxdir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @ochi12

thanks for looking into this issue, I think it would be nice to have a separate icon for snapshot rather than symlinking to the cheese icon. I know few people coming from past ubuntu releases have both apps installed so it would be confusing

my suggestion would be to have the round lens icon for snapshot without camera body

@ochi12
Copy link
Contributor Author

ochi12 commented Nov 10, 2024

hi @ochi12

thanks for looking into this issue, I think it would be nice to have a separate icon for snapshot rather than symlinking to the cheese icon. I know few people coming from past ubuntu releases have both apps installed so it would be confusing

@Muqtxdir Well I might work on it but my "guess" is camera-app.png is made as a link target for any camera app that ships with ubuntu by default. In this case the new replacement is Snapshot

The cheese Icon just feels nostalgic

Option 1

my suggestion would be to have the round lens icon for snapshot without camera body


As Ubuntu Stated, ![ If we already have a similar design, copy it and modify it, rather than making an icon from scratch](https://github.com/ubuntu/yaru/wiki/%234-Help-for-creating-yaru-icons), I might just extract the lens from the cheese icon and tweak it for `pixel fitting`.

Option 2

removing the cheese link instead.

@Muqtxdir
Copy link
Member

please go with your suggested option1

@ochi12
Copy link
Contributor Author

ochi12 commented Nov 10, 2024

please go with your suggested option1


It's pretty late right now I need some sleep. I will work on it tomorrow

@ochi12 ochi12 force-pushed the link_gnome_snapshot_to_camera_app_icon branch from 4fd6e40 to c303d69 Compare November 11, 2024 03:56
@ochi12
Copy link
Contributor Author

ochi12 commented Nov 11, 2024

@Muqtxdir @Feichtmeier new changes...

I actually made mistake pushing the changes. there are not commit message because I clone the supposedly correct commit the force push it since I'm ahead already

Tested it alongside other yaru icons to see if it fits the aesthetics.
image
image

Copy link
Member

@Muqtxdir Muqtxdir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 🧡

@ochi12
Copy link
Contributor Author

ochi12 commented Nov 12, 2024

@Feichtmeier I need some approval in symbolic icon changes

Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot @ochi12 !

@Muqtxdir Muqtxdir merged commit e91be1a into ubuntu:master Nov 18, 2024
3 checks passed
Muqtxdir added a commit that referenced this pull request Nov 20, 2024
* icons: Update rendered icons and symlinks

* New upstream symbolic icons list for gnome-system-monitor symbolics (#4099)

* New upstream symbolic icons list for gnome-calendar symbolics (#4087)

* New upstream symbolic icons list for evince symbolics (#4085)

* New upstream symbolic icons list for gnome-control-center symbolics (#4028)

* New upstream symbolic icons list for gnome-software symbolics (#4002)

* Update gnome-system-monitor symbolics

* Update gnome-calendar symbolics

* Update gnome-control-center symbolics

* Update gnome-software symbolics

* gnome-shell: Use button style for auth dialog list items

LP: #2080321

* build: Bump version to 24.10.4

* Update changelog

* Upload to oracular

* gnome-shell: Add missing keyboard-zwnj-symbolic icon

* Initial revamp watch standby and watch progress

* Added redesigned org.gnome.Software icon (#4157)

* Created org.gnome.Snapshot Link Targetting the camera-app icon.  (#4159)

* created symbolic links named org.gnome.Snapshot pointing to camera-app to supliment missing yaru icon for gnome-snapshot

* replace gnome-snapshot links targeting camera-app<or -symbolic>.<png or svg> with custom icon instead

* reworked org.gnome.Snapshot-symbolic

* GnomeShell: Yaruify upstream icons (#4138)

* GnomeShell: Yaruify upstream icons

* chore: optimize `actions` symbolics

* chore: optimize symbolics under `status`

---------

Co-authored-by: Muqtxdir <[email protected]>

* build(deps): bump actions/setup-python from 5.2.0 to 5.3.0 (#4150)

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.2.0 to 5.3.0.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v5.2.0...v5.3.0)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fixed jitter issue in watch.ani by correcting watch.in typo in last line

* generated watch and wait ani for x11 and w32 with no jitter issue

* updated left_ptr_watch: use solid spinner bg instead of gradient to reduce noise small size

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: 3v1n0 <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Paul Kepinski <[email protected]>
Co-authored-by: Marco Trevisan (Treviño) <[email protected]>
Co-authored-by: Muqtxdir <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants