Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: remove hardcoded colors and darken dark base color to improve contrast of dark theme and light theme text #957

Merged
merged 2 commits into from
Nov 13, 2024
Merged

feat!: remove hardcoded colors and darken dark base color to improve contrast of dark theme and light theme text #957

merged 2 commits into from
Nov 13, 2024

Conversation

Feichtmeier
Copy link
Member

@Feichtmeier Feichtmeier commented Nov 5, 2024 •
edited
Loading

  • darken dark base color ("Jet") -> better contrast for both light and dark themes
  • replace YaruColors with variable colors form the function arguments
  • get shades by using the scale function
Bildschirmfoto 2024-11-08 um 18 12 07 Bildschirmfoto 2024-11-08 um 18 12 14 Bildschirmfoto 2024-11-08 um 18 16 56 Bildschirmfoto 2024-11-08 um 18 14 00 Bildschirmfoto 2024-11-08 um 18 12 37 Bildschirmfoto 2024-11-08 um 18 12 29 Bildschirmfoto 2024-11-08 um 18 14 32 Bildschirmfoto 2024-11-08 um 18 14 16

Fixes #845

@Feichtmeier Feichtmeier changed the title feat!(colors): remove hardcoded colors and darken dark base color to improve contrast of dark theme and light theme text feat!: remove hardcoded colors and darken dark base color to improve contrast of dark theme and light theme text Nov 5, 2024
@Feichtmeier
feat!(colors): remove hardcoded colors and darken dark base color to …
1604d36 
…improve contrast of dark theme and light theme text
@Feichtmeier Feichtmeier marked this pull request as ready for review November 8, 2024 17:17
Jupi007
Jupi007 approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Feichtmeier Feichtmeier merged commit 855e4d5 into main Nov 13, 2024
6 of 7 checks passed
@Feichtmeier Feichtmeier deleted the feat/darker branch November 13, 2024 17:14
@github-actions github-actions bot mentioned this pull request Nov 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jupi007 Jupi007 Jupi007 approved these changes

@spydon spydon spydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove hardcoded colors to allow Custom/flavor/hc background colors
3 participants
@Feichtmeier @spydon @Jupi007