fix: HighContrast YaruMasterTile, move Example theme buttons to side pane #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pane - rework example to use watch_it instead of ubuntu service and provider
Feichtmeier
force-pushed
the
fix_high_contrast_master_tiles_rework_example
branch
from
7f4ec1b
to
71b32c8
Compare
|
The golden test fails however I checked with a color picker on macos: Bildschirmaufnahme.2024-10-27.um.15.30.42.mov |
|
I think those icons should be moved to a hamburger menu, just like the text-editor app: |
I agree with you but since we do not have popovers in yaru.dart the best you can get with material is this Bildschirmaufnahme.2024-10-27.um.17.56.29.movsince this PR fixes an issue with YaruMasterTile, can we do this in a follow up? |
This was referenced Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently YaruMasterTile had some custom text color and bg due to an animated container.
Now it uses the list tile theme, this also needed a material widget behind every tile, which we should prbly have done before :P
It was annoying to switch to the material theme page every time to use the theme buttons so I moved them out of those theme pages which needed a rework. So I also made a change to use watch_it instead of ubuntu service and provider
Bildschirmaufnahme.2024-10-27.um.15.16.18.mov