Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update goldens and test values for YaruPanedView #937

Merged
merged 2 commits into from
Oct 18, 2024
Merged

chore: Update goldens and test values for YaruPanedView #937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c421cfc
chore: Update goldens
spydon Oct 18, 2024
171dfdb
test: Fix YaruPanedView width expected values
spydon Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified test/widgets/goldens/yaru_master_detail-page-landscape-dark.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified test/widgets/goldens/yaru_master_detail-page-landscape-spacer-dark.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified test/widgets/goldens/yaru_master_detail-page-landscape-subtitle-dark.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
16 changes: 8 additions & 8 deletions test/widgets/yaru_paned_view_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ void main() {

expect(panedViewRect.width, 500);
expect(paneRect.width, 200);
expect(pageRect.width, 299);
expect(pageRect.width, 284);

await binding.setSurfaceSize(const Size(200, 500));
await tester.pump();
Expand All @@ -173,7 +173,7 @@ void main() {

expect(panedViewRect.width, 200);
expect(paneRect.width, 100);
expect(pageRect.width, 99);
expect(pageRect.width, 84);
},
);
}
Expand Down Expand Up @@ -203,7 +203,7 @@ class FixedPaneTestVariant {
paneSide: paneSide,
),
expectedPaneSize = const Size(200, 500),
expectedPageSize = const Size(299, 500);
expectedPageSize = const Size(284, 500);

FixedPaneTestVariant.vertical({
required YaruPaneSide paneSide,
Expand All @@ -214,7 +214,7 @@ class FixedPaneTestVariant {
paneSide: paneSide,
),
expectedPaneSize = const Size(500, 200),
expectedPageSize = const Size(500, 299);
expectedPageSize = const Size(500, 284);

final YaruFixedPaneDelegate layoutDelegate;
final TextDirection textDirection;
Expand Down Expand Up @@ -251,12 +251,12 @@ class ResizablePaneTestVariant {
paneSide: paneSide,
),
expectedInitialPaneSize = const Size(200, 500),
expectedInitialPageSize = const Size(299, 500),
expectedInitialPageSize = const Size(284, 500),
offset = Offset(offset, 0),
expectedResizedPaneSize =
Size(200 + (expectedSide == Side.left ? offset : -offset), 500),
expectedResizedPageSize =
Size(299 - (expectedSide == Side.left ? offset : -offset), 500);
Size(284 - (expectedSide == Side.left ? offset : -offset), 500);

ResizablePaneTestVariant.vertical({
required YaruPaneSide paneSide,
Expand All @@ -270,12 +270,12 @@ class ResizablePaneTestVariant {
paneSide: paneSide,
),
expectedInitialPaneSize = const Size(500, 200),
expectedInitialPageSize = const Size(500, 299),
expectedInitialPageSize = const Size(500, 284),
offset = Offset(0, offset),
expectedResizedPaneSize =
Size(500, 200 + (expectedSide == Side.top ? offset : -offset)),
expectedResizedPageSize =
Size(500, 299 - (expectedSide == Side.top ? offset : -offset));
Size(500, 284 - (expectedSide == Side.top ? offset : -offset));

final YaruResizablePaneDelegate layoutDelegate;
final TextDirection textDirection;
Expand Down
Loading