-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: YaruSplitButton #928
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
But I think it would be better to have a more generic implementation: something like a YaruGroupedButton widget, which could be more versatile 🤔
what do you mean? like the position of the dropdown? |
In my idea, we could add as much item as we want, with any role, just like this: https://getbootstrap.com/docs/4.0/components/button-group/#nesting |
hm I don't know if the positioning of the menu will work then but maybe its totally possible |
Yes, and this specialized widget could be a shortcut to the generic grouped button one. |
3433d7b
to
52cff19
Compare
Merged it with ref instead of fixes so we can work on it more if we want to |
Looks great! 😍 |
Either a list of poupmenuitems needs to be provided or an onOptionButtonPressed callback
Question was if the list of options/callback should still be active if the main action is null/disabled?
Ref #912