maint: use nolint instead of nosec for gosec #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The nosec directive is broken as of gosec 2.19 -- we can work around this by using the nolint directive from golangci-lint. The main drawback is that this disables the entire linter, not just one rule, but I still kept the rule name for reference. After this is merged we can bump golangci-lint to 1.56.2.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #948 +/- ##
=======================================
Coverage 86.04% 86.04%
=======================================
Files 78 78
Lines 6886 6886
=======================================
Hits 5925 5925
Misses 621 621
Partials 340 340 ☔ View full report in Codecov by Sentry. |
This has been deprecated since v1.48.0 and now fully deactivated with v1.57.0 of golangci-lint, meaning it will not run at all anymore. Unfortunately there isn't a good replacement for this yet, but we'll have to live without it until something else comes up.
denisonbarbosa
approved these changes
Mar 20, 2024
didrocks
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
nosecdirective is broken as of gosec 2.19 -- we can work around this by using thenolintdirective from golangci-lint. The main drawback is that this disables the entire linter, not just one rule, but I still kept the rule name for reference.After this is merged we can bump golangci-lint to
1.56.21.57.0.