feat: Check init tasks

.github/actions/download-rootfs/action.yaml

@@ -75,17 +75,31 @@ runs:
         foreach ($release in $releaseList) {
           $data = $release -split "\s+"
 
+          if ($data.Count -lt 2) {
+            Write-Output "Error: not enough fields in release info: $release"
+            $allSuccess = $false
+            continue
+          }
+
           # $name is the one in inputs.distros
           $name = $data[0]
-          $file = ".\${name}.tar.gz"
           $url = $data[1]
 
+          if ($name.Length -eq 0 -or $url.Length -eq 0) {
+            Write-Output "Error: empty fields in release info: $release"
+            $allSuccess = $false
+            continue
+          }
+
+          $file = ".\${name}.tar.gz"
+
           & ${{ github.action_path }}\download-rootfs.ps1 -Path "${file}" -URL "$url"
           if ( ! $? ) {
             $allSuccess = $false
             Write-Output "Error: Could not download ${name}"
           }
 
+          $allSuccess = $true
           Write-Output "::endgroup::"
         }
 

.github/workflows/build-pr.yaml

@@ -25,7 +25,9 @@ jobs:
           path: repo
       - name: Copy under workDir (which has more space to build the package)
         shell: bash
+        # Bash.exe wouldn't know how to handle the symlinks inside docs/ without the export below.
         run: |
+          export MSYS=winsymlinks:nativestrict
           mkdir -p $(dirname ${{ env.workDir }})
           mv ${GITHUB_WORKSPACE}/repo ${{ env.workDir }}
           cd ${{ env.workDir }}

.github/workflows/e2e.yaml

@@ -4,7 +4,7 @@ on:
   pull_request:
     paths-ignore:
       - docs/**
-      - *.md
+      - "*.md"
 concurrency: azure-vm
 
 env:
@@ -28,9 +28,10 @@ jobs:
     needs: vm-setup
     env:
       rootFsCache: "${env:USERPROFILE}\\Downloads\\rootfs"
-      distroName: Ubuntu-Preview
-      appID: UbuntuPreview
-      launcher: ubuntupreview.exe
+      # TODO: Move this to "Ubuntu" once we have backported everything and Ubuntu is transitionned to 24.04
+      distroName: Ubuntu-24.04
+      appID: Ubuntu24.04LTS
+      launcher: ubuntu2404.exe
     steps:
       - name: Checkout
         uses: actions/checkout@v3
@@ -88,7 +89,7 @@ jobs:
           Write-Output "::endgroup::"
 
           Write-Output "::group::Tests"
-          go test .\launchertester\ -timeout 15m -run TestBasicSetup --distro-name '${{ env.distroName }}' --launcher-name '${{ env.launcher }}'
+          go test .\launchertester\ -timeout 30m --distro-name '${{ env.distroName }}' --launcher-name '${{ env.launcher }}'
           $exitStatus=$?
           Write-Output "::endgroup::"
           if ( ! $exitStatus ) { Exit(1) }

DistroLauncher/DistroLauncher.cpp

@@ -37,6 +37,10 @@ HRESULT InstallDistribution(bool createUser)
         return hr;
     }
 
+    if (Ubuntu::CheckInitTasks(g_wslApi, createUser)) {
+        return ERROR_SUCCESS;
+    }
+
     // Create a user account.
     if (createUser) {
         Helpers::PrintMessage(MSG_CREATE_USER_PROMPT);

DistroLauncher/DistroLauncher.vcxproj

@@ -140,6 +140,7 @@
   <ItemGroup>
     <ClInclude Include="DistributionInfo.h" />
     <ClInclude Include="Helpers.h" />
+    <ClInclude Include="Ubuntu\InitTasks.h" />
     <ClInclude Include="resource.h" />
     <ClInclude Include="stdafx.h" />
     <ClInclude Include="targetver.h" />
@@ -149,6 +150,9 @@
     <ClCompile Include="DistributionInfo.cpp" />
     <ClCompile Include="Helpers.cpp" />
     <ClCompile Include="DistroLauncher.cpp" />
+    <ClCompile Include="Ubuntu\InitTasks.cpp">
+      <AdditionalIncludeDirectories>$(ProjectDir);%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
+    </ClCompile>
     <ClCompile Include="stdafx.cpp">
       <PrecompiledHeader>Create</PrecompiledHeader>
     </ClCompile>

DistroLauncher/DistroLauncher.vcxproj.filters

@@ -33,6 +33,9 @@
     <ClInclude Include="Helpers.h">
       <Filter>Header Files</Filter>
     </ClInclude>
+    <ClInclude Include="Ubuntu\*.h">
+      <Filter>Header Files</Filter>
+    </ClInclude>
   </ItemGroup>
   <ItemGroup>
     <ClCompile Include="DistroLauncher.cpp">
@@ -50,6 +53,9 @@
     <ClCompile Include="DistributionInfo.cpp">
       <Filter>Source Files</Filter>
     </ClCompile>
+    <ClCompile Include="Ubuntu\*.cpp">
+      <Filter>Source Files</Filter>
+    </ClCompile>
   </ItemGroup>
   <ItemGroup>
     <ResourceCompile Include="DistroLauncher.rc">

DistroLauncher/Ubuntu/.clang-format

@@ -0,0 +1,11 @@
+BasedOnStyle: Google
+---
+Language: Cpp
+AllowShortBlocksOnASingleLine: Empty
+AllowShortFunctionsOnASingleLine: All
+ColumnLimit: 100
+DerivePointerAlignment: false
+InsertNewlineAtEOF: true
+PointerAlignment: Left
+# We need to keep stdafx.h as the first include of any cpp file.
+SortIncludes: false