-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep track of ignored errors, resolves #2533 #2681
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2681 +/- ##
==========================================
+ Coverage 76.61% 77.27% +0.66%
==========================================
Files 29 29
Lines 962 968 +6
==========================================
+ Hits 737 748 +11
+ Misses 225 220 -5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out I only have two pretty opinionated comments, LGTM otherwise so feel free to ignore :)
Users are often reluctant to report the first error they run into and chose to ignore it. If something does not work, they report it later and the error gets buried in the log. We should keep track of these and include them in the bug reports.
If any errors have been ignored, the PASS reporting option should be disabled. Even if everything worked, the correct status to report in this case is WONKY, as a workaround was required.