Fix restart button when Done #2610
Conversation
llewelld
force-pushed
the
fix-restart
branch
2 times, most recently
from
91ba393
to
b82ce16
Compare
Codecov Report
@@ Coverage Diff @@
## master #2610 +/- ##
==========================================
+ Coverage 76.20% 76.61% +0.41%
==========================================
Files 29 29
Lines 954 958 +4
==========================================
+ Hits 727 734 +7
+ Misses 227 224 -3
Continue to review full report at Codecov.
|
| return core.prepare("a", true).then(() => { | ||
| expect(core.readConfigFile).toHaveBeenCalledWith("a"); | ||
| expect(core.readConfigFile).toHaveBeenCalledTimes(1); | ||
| core.readConfigFile.mockRestore(); |
There was a problem hiding this comment.
You should restore the mocks in a .finally to make sure you never influence other test cases
There was a problem hiding this comment.
Could you provide me a bit more guidance here please?
Is this different from the restore before each of the tests?
There was a problem hiding this comment.
should not be needed, but jest can be weird sometimes
There was a problem hiding this comment.
Ah, I was looking for the config option, didn't notice the manual beforeEach - then you shouldn't need the restores at all
There was a problem hiding this comment.
Just to clarify, I'm happy to make changes here, but I'd still need some guidance on what's needed.
| return core.prepare("a", true).then(() => { | ||
| expect(core.readConfigFile).toHaveBeenCalledWith("a"); | ||
| expect(core.readConfigFile).toHaveBeenCalledTimes(1); | ||
| core.readConfigFile.mockRestore(); |
There was a problem hiding this comment.
should not be needed, but jest can be weird sometimes
When the flashing process completes the user is asked if they want to flash another device. Currently the button seems to do nothing; these changes return the app back to the start screen to allow the user to attempt another flashing process. Co-authored-by: Johannah Sprinz <[email protected]>
Adds a unit test for the restart event.
|
Could you please |
When the flashing process completes the user is asked if they want to
flash another device. Currently the button seems to do nothing; these
changes return the app back to the start screen to allow the user to
attempt another flashing process.