main: do not lower priority of rendering when in background #2546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amartinz
force-pushed
the
disable-renderer-backgrounding
branch
from
1882922
to
4f7279b
Compare
amartinz
commented
Apr 26, 2022
src/main.js
Outdated
| @@ -29,6 +29,12 @@ const reporter = require("./lib/reporter.js"); | |||
| const menuManager = require("./lib/menuManager.js"); | |||
| const core = require("./core/core.js"); | |||
|
|
|||
| // Do not lower priority of rendering when in background | |||
| // - See: https://www.electronjs.org/de/docs/latest/api/command-line-switches#--disable-renderer-backgrounding | |||
| if (typeof app.commandLine !== 'undefined') { | |||
There was a problem hiding this comment.
Had to add the check because jest does not know about app.commandLine.
Please let me know, if there is a better way to solve this :)
Codecov Report
@@ Coverage Diff @@
## master #2546 +/- ##
==========================================
- Coverage 76.20% 76.15% -0.06%
==========================================
Files 29 29
Lines 954 956 +2
==========================================
+ Hits 727 728 +1
- Misses 227 228 +1
Continue to review full report at Codecov.
|
This prevents rendering getting slow when switching to other applications while installing, which results in the installer interacting with the device while GUI is trying to catch up with the installation process. Change-Id: I201defba33d76322d3405d254b7a4b6ba3530bd1 Signed-off-by: Alexander Martinz <[email protected]>
amartinz
force-pushed
the
disable-renderer-backgrounding
branch
from
4f7279b
to
bb6c484
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents rendering getting slow when switching to other
applications while installing, which results in the installer
interacting with the device while GUI is trying to catch up
with the installation process.