Fixes for building, typo and windows ci #2493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes: [!] Error: Invalid value "iife" for option "output.format" - UMD and IIFE output formats are not supported for code-splitting builds. See: https://rollupjs.org/guide/en/#outputinlinedynamicimports Change-Id: Ia4e793b924a878133ce7c279a65703bf043bc973 Signed-off-by: Alexander Martinz <[email protected]>
Configure should be lowercase. Change-Id: Ia670a426cd65e2cc49c7cd31b499ea6162aa6fc2 Signed-off-by: Alexander Martinz <[email protected]>
amartinz
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2493 +/- ##
=======================================
Coverage 73.71% 73.71%
=======================================
Files 28 28
Lines 917 917
=======================================
Hits 676 676
Misses 241 241 Continue to review full report at Codecov.
|
Flohack74
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getEnvironmentcall is very slow on windows, causing the tests on windows to time out and fail the test suite.There is also a change to rollup to fix build breakage because of code splitting attempts.
Also fix a case typo.