Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial wait-for-device should support fastboot as well #902

Closed
NeoTheThird opened this issue Oct 4, 2019 · 0 comments · Fixed by #1487
Closed

Initial wait-for-device should support fastboot as well #902

NeoTheThird opened this issue Oct 4, 2019 · 0 comments · Fixed by #1487
Assignees
@NeoTheThird
Labels
enhancement a new feature or an improvement of existing functionality

Comments

@NeoTheThird
Copy link
Member

Currently, our WaitForDevice function only supports devices accessible over adb. There's not really a reason why we wouldn't be able to also use fastboots' wait for device implementation from our promise-android-tools lib and then enquire the device id using fastboot getvar device.
@NeoTheThird NeoTheThird added enhancement a new feature or an improvement of existing functionality help wanted help from community contributors would be appreciated labels Oct 4, 2019
@NeoTheThird NeoTheThird mentioned this issue Nov 24, 2019
Closed
@NeoTheThird NeoTheThird removed the help wanted help from community contributors would be appreciated label Nov 5, 2020
@NeoTheThird NeoTheThird self-assigned this Nov 5, 2020
NeoTheThird added a commit that referenced this issue Nov 5, 2020
@NeoTheThird
Allow initial wait function to use fastboot to detect and identify de…
8018d64 
…vices, resolves #902
@NeoTheThird NeoTheThird linked a pull request Nov 8, 2020 that will close this issue
Near-rewrite of promise-android-tools #1487
Merged
NeoTheThird added a commit that referenced this issue Nov 9, 2020
@NeoTheThird
Refactoring of promise-android-tools (#1487)
ed7974a 
* testing ground for promise-android-tools refactoring

* Allow initial wait function to use fastboot to detect and identify devices, resolves #902

* Report progress from adb sideload and fastboot flash, resolves #1487

* Ignore irrellevant errors while preparing systemimage

* tweak error handling

* Move to released module

* update deps

* remove defaultMeta from winston, resolves #1507

* Hide speed after download, resolves #1509

* Allow dismissing report prompt temporarily, resolves #1508
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NeoTheThird NeoTheThird

Labels
enhancement a new feature or an improvement of existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Near-rewrite of promise-android-tools ubports/ubports-installer
1 participant
@NeoTheThird