Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsupported devices not properly recognized if served by old devices API #692

Closed
NeoTheThird opened this issue Mar 10, 2019 · 0 comments · Fixed by #710
Closed

Unsupported devices not properly recognized if served by old devices API #692

NeoTheThird opened this issue Mar 10, 2019 · 0 comments · Fixed by #710
Assignees
Labels
bug a bug in the software itself

Comments

@NeoTheThird
Copy link
Member

If an unsupported device served by the old devices API is recongnized by the Installer, no unsupported error is thrown. Instead, the installation process starts and fails due to unsufficient api data. This will be resolved by moving to the new API.

@NeoTheThird NeoTheThird added the bug a bug in the software itself label Mar 10, 2019
@NeoTheThird NeoTheThird self-assigned this Mar 10, 2019
NeoTheThird added a commit that referenced this issue Mar 10, 2019
These are the initial steps of our long expected refactoring.

- Include the command-line interface in the normal app (even though it
does not do anything yet)
- Tame the crossfiring commands, fixes #187 and possibly many other
issues
- Fixes stupid bug where we tried to execute [Object]
- More intuitive loading bars
- Improve logging by, like, a lot
- Remove a lot of unused code
- Improvements of code quality in some areas
- Move stuff around
- More useful event handling
- Finish adb-support snapd interface implementation, fixes #258
- Implement ubports-api-node-module
- Use new (a year old, holy shit time is flying!) API server, fixes #692
- Shut the child process up, fixes #216
NeoTheThird added a commit that referenced this issue Mar 10, 2019
These are the initial steps of our long expected refactoring.

- Include the command-line interface in the normal app (even though it
does not do anything yet)
- Tame the crossfiring commands, fixes #187 and possibly many other
issues
- Fixes stupid bug where we tried to execute [Object]
- More intuitive loading bars
- Improve logging by, like, a lot
- Remove a lot of unused code
- Improvements of code quality in some areas
- Move stuff around
- More useful event handling
- Finish adb-support snapd interface implementation, fixes #258
- Implement ubports-api-node-module
- Use new (a year old, holy shit time is flying!) API server, fixes #692
- Shut the child process up, fixes #216
- Fix macos paths
NeoTheThird added a commit that referenced this issue Mar 17, 2019
## New features

- Allow the user to reconnect their device if the connection gets lost
- New *beautiful* animations for downloading and pushing files
- Include the command-line interface in the normal app (not fully implemented yet)
- Use --debug and --verbose instead of env vars, resolves #704
- Remove google fonts, because fuck google
- Clean cache before installing, resolves #6

## Bugfixes

- Tame the cross-firing events, fixes #187 and possibly many other
issues
- Finish adb-support snapd interface implementation, fixes #258
- Implement ubports-api-node-module, fixes #692, resolves #7
- Use new (a year old, holy shit time is flying!) API server, fixes #692
- Shut the child process up, fixes #216
- Fix macos paths, fixes #430, fixes #553, fixes #120, fixes #92
- Fixes stupid bug where we tried to execute [Object]
- Fixes #703 , where custom tools were not executed on asar convenience function usage
- Introduce a --simulate option (still experimental), resolves #706
- Implement --force-fallback, resolves #705 
- Implement introduce --no-root option
- Fix #716, `fastboot boot` issue on Meizu Pro 5

## General improvements related to unreported or distributed issues

- More intuitive loading bars
- Improve logging by, like, a lot
- Remove a lot of unused code
- Improvements of code quality in some areas
- Move stuff around
- More useful event handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug a bug in the software itself
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant