-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable both user and system flatpak installs #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsherman
changed the title
feat: add args for package manager
feat: enable both user and system flatpak installs
Apr 12, 2023
bsherman
commented
Apr 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the changes!
Renaming "package_manager_args" to "package_manager_defaults" makes sense to me. And I also like the ability to override on a per-package basis.
marcoceppi
approved these changes
Apr 12, 2023
Arcitec
added a commit
to Arcitec/os
that referenced
this pull request
May 13, 2023
- The first screen's "Pick some applications to get started" has been replaced with a friendly welcoming message. - The second screen's difficult-to-understand "WARNING: This will modify your Flatpaks if you are rebasing!" has been replaced with an explanation of what it actually does. - The application setup screen is now titled "Application Installer", since the previous title sounded too much like a silly rhyme. It's a minor change. - All Flatpaks now default to system-wide install thanks to the great work of bsherman at ublue-os/yafti#82. This saves tons of disk space for multi-user systems. - The "system application" category have been split up into GNOME apps and every other system app, so that people on other desktop environments don't get all the GNOME apps. - Apps that had too vague descriptions have been renamed to their full names, such as "Backup -> Deja Dup Backups". - All app lists have been sorted alphabetically. - Non-inclusive language in descriptions has been changed. - Added SteamTinkerLaunch as a suggestion for the Steam category, which is the best tool for managing Steam game configurations and Proton installations, albeit very advanced since it can do practically anything the gamer needs. :)
xynydev
pushed a commit
to blue-build/legacy-template
that referenced
this pull request
May 14, 2023
- The first screen's "Pick some applications to get started" has been replaced with a friendly welcoming message. - The second screen's difficult-to-understand "WARNING: This will modify your Flatpaks if you are rebasing!" has been replaced with an explanation of what it actually does. - The application setup screen is now titled "Application Installer", since the previous title sounded too much like a silly rhyme. It's a minor change. - All Flatpaks now default to system-wide install thanks to the great work of bsherman at ublue-os/yafti#82. This saves tons of disk space for multi-user systems. - The "system application" category have been split up into GNOME apps and every other system app, so that people on other desktop environments don't get all the GNOME apps. - Apps that had too vague descriptions have been renamed to their full names, such as "Backup -> Deja Dup Backups". - All app lists have been sorted alphabetically. - Non-inclusive language in descriptions has been changed. - Added SteamTinkerLaunch as a suggestion for the Steam category, which is the best tool for managing Steam game configurations and Proton installations, albeit very advanced since it can do practically anything the gamer needs. :)
RoyalOughtness
pushed a commit
to secureblue/secureblue
that referenced
this pull request
Nov 27, 2023
- The first screen's "Pick some applications to get started" has been replaced with a friendly welcoming message. - The second screen's difficult-to-understand "WARNING: This will modify your Flatpaks if you are rebasing!" has been replaced with an explanation of what it actually does. - The application setup screen is now titled "Application Installer", since the previous title sounded too much like a silly rhyme. It's a minor change. - All Flatpaks now default to system-wide install thanks to the great work of bsherman at ublue-os/yafti#82. This saves tons of disk space for multi-user systems. - The "system application" category have been split up into GNOME apps and every other system app, so that people on other desktop environments don't get all the GNOME apps. - Apps that had too vague descriptions have been renamed to their full names, such as "Backup -> Deja Dup Backups". - All app lists have been sorted alphabetically. - Non-inclusive language in descriptions has been changed. - Added SteamTinkerLaunch as a suggestion for the Steam category, which is the best tool for managing Steam game configurations and Proton installations, albeit very advanced since it can do practically anything the gamer needs. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I love yafti but need the option to do flatpak system installs not only user installs.
This PR enables the package/install screens to use a new key in the config
package_manager_args
which itself is adict
of keys mapping to the respective package manager plugin'sinstall
method.This allows a user of Yafti to enable system flatpak installs by adding the following to the yafti.yml:
However, the solution is generic such that it could be used for other requirements.