WIP - Minor improvements #229
Conversation
| furo = "*" | ||
| myst-parser = "*" | ||
| myst-nb = "*" | ||
| sphinx = "*" | ||
| sphinx-autobuild = "*" | ||
| sphinx-autodoc-typehints = "*" | ||
| sphinx-copybutton = "*" | ||
| sphinxcontrib-mermaid = "*" | ||
| sphinxcontrib-napoleon = "*" | ||
| sphinx-design = "*" | ||
| sphinx-inline-tabs = "*" |
There was a problem hiding this comment.
Don't use *, use some version boundaries. Generally, when adding dependencies use poetry add <package> or poetry add --group docs <package> it'll resolve the package and add the latest version tag.
There was a problem hiding this comment.
Yeah, this needs to be updated thanks for pointing it out. Likely missed as I had all the intention to get GitHub pages up and running with some nice docs.
| [distutils] | ||
| index-servers = forgejo | ||
|
|
||
| [forgejo] | ||
| repository = https://things.com | ||
| username = {username} | ||
| password = {password} |
There was a problem hiding this comment.
Not sure what this file is for
There was a problem hiding this comment.
local pypi server template. will remove if you want.
| __version__: str = "0.9.0-beta1" | ||
| __name__: str = "yafti" |
There was a problem hiding this comment.
This shouldn't be needed. It's already tracked in the pyproject.toml
There was a problem hiding this comment.
just personal preference I guess. will remove if you hate it.
There was a problem hiding this comment.
Don't hate it, but it means everyone needs to know two places to track version - pyproject.toml has it and should be the source of truth for versions
| Copyright 2023 Marco Ceppi | ||
| Copyright 2024 Alex Banna |
There was a problem hiding this comment.
You can keep multiple copyright headers. My copyright doesn't go away because theyre's a new maintainer. Add you name below and the year it started.
| """ | ||
| typer.echo(f"Platform: {sys.platform}") | ||
| typer.secho(f"Python Version: {sys.version}") | ||
| typer.secho(f"Yafti Version: {__version__}") |
There was a problem hiding this comment.
There was a problem hiding this comment.
Actually, that is not the best way, Py3 has importlib.metadata.version("yafti") which will do what you want
yafti-2024-05-01-00-23-01.webm |
No description provided.