Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(iso): added KS and ISO generation #99

Merged
merged 26 commits into from
Apr 2, 2023
Merged

chore(iso): added KS and ISO generation #99

merged 26 commits into from
Apr 2, 2023

Conversation

bigpod98
Copy link
Contributor

@bigpod98 bigpod98 commented Apr 2, 2023

No description provided.

@bigpod98 bigpod98 requested a review from castrojo as a code owner April 2, 2023 13:42
@castrojo
Copy link
Member

castrojo commented Apr 2, 2023

For other reviewers, here's the output: https://github.com/bigpod98/main/releases/tag/v1.0.4

…omponents--release-please-action

chore(main): release 1.0.5
@castrojo castrojo merged commit 36ac6a8 into ublue-os:main Apr 2, 2023
@lamarios
Copy link

lamarios commented Apr 3, 2023

How to trigger this one ? I maintain my own fork of ublue-os and wish to generate my ISO, I modified my yml accordingly (image names/ repos etc...) but it gets skipped on push build. I tried to create a new release but that did not trigger it either.

@castrojo
Copy link
Member

castrojo commented Apr 3, 2023

The action in my bluefin repo is simplified which might be useful: https://github.com/ublue-os/bluefin/blob/main/.github/workflows/release-please.yml

Would you mind posting in the discussion forum? This stuff is pretty fresh and it's mostly undocumented, I'd love to at least capture that so we can start to document this for the next person.

Link us up to your repo and I'd be happy to take a look, thanks for playing with this, this is the kind of thing we need to help document it for the next person!

@lamarios
Copy link

lamarios commented Apr 3, 2023

done

I'm not just playing with it :) all my machines are running this. This project is great ! Can't wait for the yafti integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants