Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Bump isogenerator to v2.1.0 #303

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Conversation

EyeCantCU
Copy link
Member

@EyeCantCU EyeCantCU commented Aug 16, 2023

This bumps isogenerator to v2.1.0

@KyleGospo KyleGospo added this pull request to the merge queue Aug 16, 2023
@castrojo
Copy link
Member

Please revert, we do this on purpose, I can explain when I'm not on mobile

@castrojo
Copy link
Member

Or rather, pin the explicit version!

@EyeCantCU EyeCantCU removed this pull request from the merge queue due to a manual request Aug 16, 2023
@EyeCantCU
Copy link
Member Author

All right. I'll fix this up

@castrojo
Copy link
Member

For some context, this is so when if someone is revving on the isogenerator to test in other images we can always ensure that main/nvidia are releaseable on a known-good version.

Then we explicitly bump after testing. Thanks!

@EyeCantCU EyeCantCU changed the title chore(ci): Always use latest isogenerator chore(ci): Bump isogenerator to v2.1.0 Aug 16, 2023
@EyeCantCU
Copy link
Member Author

That makes a lot of sense. Thank you for explaining that to me. Wouldn't want to ship a bad ISO

@KyleGospo KyleGospo added this pull request to the merge queue Aug 16, 2023
Merged via the queue into main with commit 42343fa Aug 16, 2023
13 checks passed
@KyleGospo KyleGospo deleted the latest-isogenerator branch August 16, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants