Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: install NetworkManager-openvpn #79

Merged
merged 1 commit into from
Oct 4, 2024
Merged

feat: install NetworkManager-openvpn #79

merged 1 commit into from
Oct 4, 2024

Conversation

p5
Copy link
Member

@p5 p5 commented Oct 4, 2024

Closes #78

This package is required for using a VPN from within Cosmic settings.

@p5 p5 requested a review from ryanabx October 4, 2024 19:54
@ryanabx
Copy link
Member

ryanabx commented Oct 4, 2024

We should probably add this to the cosmic-settings spec, no?

Copy link
Member

@ryanabx ryanabx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now though, lgtm!

@ryanabx ryanabx added this pull request to the merge queue Oct 4, 2024
@p5
Copy link
Member Author

p5 commented Oct 4, 2024

We should probably add this to the cosmic-settings spec, no?

To be honest, I don't know what belongs here and what belongs upstream. I guess since it's fairly basic functionality, it maybe should go upstream?

@ryanabx
Copy link
Member

ryanabx commented Oct 4, 2024

We should probably add this to the cosmic-settings spec, no?

To be honest, I don't know what belongs here and what belongs upstream. I guess since it's fairly basic functionality, it maybe should go upstream?

Not sure, it could be a Recommends: instead of a Requires: , I'll have to think about it more

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 4, 2024
@p5 p5 merged commit 06d2b28 into main Oct 4, 2024
8 checks passed
@p5 p5 deleted the networkmanager-openvpn branch October 4, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include network-manager-openvpn package
2 participants