-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add HPET configuration from Atomic Studio #1726
base: main
Are you sure you want to change the base?
Conversation
Do note that this is my first technical PR, and that as such this might not be the proper or preferable way of implementing this. |
@tulilirockz you might be able to give more insight in this for us as to how this works and help. |
@@ -0,0 +1 @@ | |||
dev.hpet.max-user-freq=3072 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed when you add the file in the desktop image, as the deck image is built from the desktop image and get the file through that.
If we needed the number to be different for the deck image then this file would be needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, good to know! Sending in another commit to fix this.
Cool I could approve that, shouldn't I be a maintainer or something? :-D |
After having talked to @tulilirockz about the details of this, i don't think i will be approving this as it would increase power consumption (and the desktop image is also used on laptops) and battery drain for little to no gain for gaming audio. They also mentioned that if this did get merged, make sure it does not get included in the I think this instead would make more sense as a |
Alright; with that in mind, I think it might be even better to implement as part of a |
Does setup-realtime add any kernel modules? if so it cant be done on the users end. |
No - but the
It would be the main use most likely, but there are others. I think mostly sharing the name with the package could leave less guesswork to the user? |
if it does more than audio then |
I'll convert this PR to a draft for now. |
I have to preface this by stating that I do not understand the underlying mechanisms adequately myself - but after speaking to the Atomic Studio dev last month, I'm told this tweak might help those facing audio issues, particularly on constrained handhelds - and that it should have no ill effect otherwise.
Atomic Studio currently implements it here.