Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(actions): try to recover if just fails to install #81

Merged
merged 4 commits into from
Jan 6, 2025

Conversation

ledif
Copy link
Collaborator

@ledif ledif commented Jan 4, 2025

Related to ublue-os/bluefin#2106.

Lately, there are some flaky failures for jobs while installing just. For example, in the past few days, the following jobs to build images have failed:

The command curl -L https://api.github.com/repos/casey/just/releases/latest | jq -r '.tag_name' is sometimes returning "null" instead of an actual version, but it's difficult to tell if the curl call is failing or if it's returning a payload that is being parsed incorrectly.

In either case, adding --retry to curl and if it's still null, hardcoding a known good version should do the trick for now.

@ledif ledif requested a review from castrojo as a code owner January 4, 2025 18:38
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 4, 2025
@ledif ledif requested review from NiHaiden and m2Giles January 4, 2025 18:38
@dosubot dosubot bot added the github_actions Pull requests that update GitHub Actions code label Jan 4, 2025
RealVishy
RealVishy previously approved these changes Jan 4, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 4, 2025
@m2Giles
Copy link
Member

m2Giles commented Jan 4, 2025

Something like this would be a bit more resistant

          while [[ "${JUST_VERSION:-}" =~ null || -z "${JUST_VERSION:-}" ]]
          do
            JUST_VERSION=$(curl -L https://api.github.com/repos/casey/just/releases/latest | jq -r '.tag_name')
          done

@ledif
Copy link
Collaborator Author

ledif commented Jan 6, 2025

I updated the PR based on suggestions. Could I get a re-approval please? :)

@m2Giles m2Giles enabled auto-merge January 6, 2025 00:56
@m2Giles m2Giles added this pull request to the merge queue Jan 6, 2025
Merged via the queue into ublue-os:main with commit c7e6976 Jan 6, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants