-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rider IDE project model support #248
base: main
Are you sure you want to change the base?
Conversation
…mapping and DoBuild property
…GetImplicitlyDefinedSymbols().
… Add "Minimize" and "IgnoreDefaults" parameters.
…ions properties to Module
…n file from .Rider folder
…sing solution bff file.
…ame "BuildCommands" to "BuildInfo"
…ptions of RiderGenerationContext
…ild build commands, change Clean command to remove .pdb and .pch files
Map output CppLanguageStandard and PchAction to RiderJson values.
…ument, fix generation on multiple DevEnvs
… it's working for vcxproj)
0cb8966
to
ed90d61
Compare
Hi! Thanks for the PR! Can you explain a little more about the motivation for adding Rider directly to sharpmake instead of using some of the other project generators, we are under the impression that Rider can read visual studio project files already? |
Hello @tru |
Yeah that was the speculation we had in our latest maintainer meeting. We will go ahead and review this one as soon as we have time! Thanks for the reply. |
@@ -11,6 +11,7 @@ public static class CppLanguageStandard | |||
{ | |||
public const string Cpp14 = "Cpp14"; | |||
public const string Cpp17 = "Cpp17"; | |||
public const string Cpp20 = "Cpp20"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you break out this change and submit a small PR with just this change? That one we can merge directly and doesn't have to be part of the Rider one.
Has this been abandoned? cross platform support for C++ rider projects with sharpmake would be extremely useful. |
Add support for JetBrains Rider IDE project model:
/rdjson
option;.sharpmake.cs
script.