Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to control inheriting pre-build steps #114

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

jonathansty
Copy link

By default pre-build steps of a dependency end up in the final project that added them as a dependency. I'm not sure if this is the intended behavior or not. This change adds:

  • overriding of build step inheritance behavior by using the DependencySetting enum.
  • Allow build order dependencies if the dependency is an exe. (Imagine a tool exe dependency for a pre-build step)
  • Added a sample to demonstrate build steps issue

Not sure if this code can be taken seeing as the pre build step default behavior might be wrong anyways. This is the fix I came up with which might drive a more complete fix.

@jspelletier jspelletier changed the base branch from dev to main April 6, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant