feat: fix style on tables #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Old dark mode:
New dark mode:
Old light mode:
New light mode:
|
|
Can you please use the same colors as in the code block for the alt color in the table? |
|
Please add bottom-padding to the table, it's not a footer only thing.
|
zugdev
reviewed
Nov 23, 2024
| @@ -1,8 +1,12 @@ | |||
| :root { | |||
| --dark-background: #000210; | |||
| --dark-background-half: #00021080; | |||
| --alt-dark-background: #808080; | |||
There was a problem hiding this comment.
Thanks for the hardcode refac!
|
Looks good on mobile too:
I've noticed the text looks blurry, but it seems to be in prod, I'll fix it. |
|
The blurry text is Opera's fault, it's about how they render text when DevTools is open. Since it only affects when DevTools is open it's not a relevant bug and we should not worry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #159