Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fix keyboard navigation buttons overlay #130

Merged
merged 2 commits into from
Oct 23, 2024
Merged

feat: fix keyboard navigation buttons overlay #130

merged 2 commits into from
Oct 23, 2024

Conversation

zugdev
Copy link
Contributor

@zugdev zugdev commented Oct 19, 2024

Resolves #127

@zugdev zugdev requested a review from 0x4007 as a code owner October 19, 2024 19:41
@ubiquity-os-deployer
Copy link

ubiquity-os-deployer bot commented Oct 19, 2024 •
edited
Loading

@zugdev zugdev changed the title feat: fix max-width for keyboard buttons feat: fix keyboard navigation buttons overlay Oct 19, 2024
0x4007
0x4007 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spec stated that it should be moved to the left but I suppose hiding works fine as well.

@0x4007 0x4007 merged commit 27ca00c into ubiquity:development Oct 23, 2024
1 of 2 checks passed
@ubiquity-os ubiquity-os bot mentioned this pull request Oct 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x4007 0x4007 0x4007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

keyboard navigation buttons over commit id in certain page widths
2 participants
@zugdev @0x4007