feat: add issues in URL and handle history state #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x4007
reviewed
Oct 19, 2024
| @@ -149,6 +149,40 @@ export function viewIssueDetails(full: GitHubIssue) { | |||
| modal.classList.add("active"); | |||
| modal.classList.remove("error"); | |||
| document.body.classList.add("preview-active"); | |||
|
|
|||
| updateURLWithIssueID(full.id); | |||
There was a problem hiding this comment.
Strict pascal case lint shouldnt let this work
|
Just tested. Looks like it is almost perfect. I think ideally the app mode should change to proposals when viewing a proposal though. https://4a76efd5.devpool-directory-ui.pages.dev/?issue=2499194812 This is a proposal but when I X out of the modal, its in the tasks view. Any good solution for this? |
|
Yeah that's easy will check |
|
Should be good to go now. I have added a proposal parameter to the URL if we are in proposal view. Also it changes the toggle from Directory to Proposals based on URL. |
0x4007
approved these changes
Oct 20, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #118