chore: remove css and ts for isnew and modified

ubiquity · Mar 5, 2024 · aec6f8a · aec6f8a
1 parent 7093c96
commit aec6f8a
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 58 deletions.
diff --git a/src/home/fetch-github/fetch-and-display-previews.ts b/src/home/fetch-github/fetch-and-display-previews.ts
@@ -24,7 +24,7 @@ export async function fetchAndDisplayPreviewsFromCache(sorting?: Sorting, option
     };
   }
 
-  const cachedTasks = _cachedTasks.tasks.map((task) => ({ ...task, isNew: false, isModified: false })) as TaskMaybeFull[];
+  const cachedTasks = _cachedTasks.tasks as TaskMaybeFull[];
   taskManager.syncTasks(cachedTasks);
 
   if (!cachedTasks.length) {
@@ -73,8 +73,7 @@ export function verifyGitHubIssueState(cachedTasks: TaskMaybeFull[], fetchedPrev
     if (cachedTask) {
       if (taskWithFullTest(cachedTask)) {
         const cachedFullIssue = cachedTask.full;
-        const isModified = new Date(cachedFullIssue.updated_at) < new Date(fetched.preview.updated_at);
-        const task = { ...fetched, full: cachedFullIssue, isModified };
+        const task = { ...fetched, full: cachedFullIssue };
         return task;
       } else {
         // no full issue in task
@@ -84,8 +83,6 @@ export function verifyGitHubIssueState(cachedTasks: TaskMaybeFull[], fetchedPrev
     }
     return {
       preview: fetched.preview,
-      isNew: true,
-      isModified: false,
     } as TaskNoFull;
   });
 }

diff --git a/src/home/getters/get-local-store.ts b/src/home/getters/get-local-store.ts
@@ -17,16 +17,5 @@ export function getLocalStore(key: string): TaskStorageItems | OAuthToken | null
 
 export function setLocalStore(key: string, value: TaskStorageItems | OAuthToken) {
   // remove state from issues before saving to local storage
-  if ("tasks" in value && value.tasks.length && "isNew" in value.tasks[0] && "isModified" in value.tasks[0]) {
-    const tasksWithoutState = value.tasks.map(({ preview, full }) => ({
-      preview,
-      full,
-    }));
-    localStorage[key] = JSON.stringify({
-      ...value,
-      tasks: tasksWithoutState,
-    });
-  } else {
-    localStorage[key] = JSON.stringify(value);
-  }
+  localStorage[key] = JSON.stringify(value);
 }
diff --git a/src/home/rendering/render-github-issues.ts b/src/home/rendering/render-github-issues.ts
@@ -37,13 +37,6 @@ function everyNewIssue({ taskPreview, container }: { taskPreview: TaskMaybeFull;
   issueElement.setAttribute("data-preview-id", taskPreview.preview.id.toString());
   issueElement.classList.add("issue-element-inner");
 
-  if (taskPreview.isNew) {
-    issueWrapper.classList.add("new-task");
-  }
-  if (taskPreview.isModified) {
-    issueWrapper.classList.add("modified-task");
-  }
-
   const urlPattern = /https:\/\/github\.com\/([^/]+)\/([^/]+)\//;
   const match = taskPreview.preview.body.match(urlPattern);
   const organizationName = match?.[1];

diff --git a/static/style/inverted-style.css b/static/style/inverted-style.css
@@ -321,23 +321,6 @@
   .full {
     display: unset !important;
   }
-  .new-task,
-  .modified-task {
-    position: relative;
-  }
-  .new-task::before,
-  .modified-task::before {
-    content: "";
-    display: inline-block;
-    position: absolute;
-    height: 100%;
-    width: 4px;
-    left: 0;
-    background-color: #00ffff;
-  }
-  .modified-task::before {
-    background-color: #ffff00;
-  }
   @media screen and (max-width: 804px) {
     .mid {
       display: none !important;

diff --git a/static/style/style.css b/static/style/style.css
@@ -321,23 +321,6 @@
   .full {
     display: unset !important;
   }
-  .new-task,
-  .modified-task {
-    position: relative;
-  }
-  .new-task::before,
-  .modified-task::before {
-    content: "";
-    display: inline-block;
-    position: absolute;
-    height: 100%;
-    width: 4px;
-    left: 0;
-    background-color: #0ff;
-  }
-  .modified-task::before {
-    background-color: #ff0;
-  }
   @media screen and (max-width: 804px) {
     .mid {
       display: none !important;