Solidity imported libraries should have a version #643

eugenioclrc · 2023-05-18T00:49:08Z

Currently its not clear what version of used libraries the protocolo is using;
https://github.com/ubiquity/ubiquity-dollar/blob/development/.gitmodules

What should be done:

Remove tags (because they are not working in git submodules) and add branch names to git submodules (perhaps this requires some code refactoring, make sure that libs are also updated after settings branch names)
Remove duplicate entries in git submodules

0x4007 · 2023-05-18T08:04:39Z

@rndquu @zgorizzo69 any inputs on this?

eugenioclrc · 2023-05-18T11:47:51Z

@rndquu @zgorizzo69 any inputs on this?

I could take it but first I want to hear your opinions

rndquu · 2023-05-19T07:39:40Z

@eugenioclrc

So in the end in git submodules we will have smth similar to:

[submodule "packages/contracts/lib/openzeppelin-contracts"]
	path = packages/contracts/lib/openzeppelin-contracts
	url = https://github.com/OpenZeppelin/openzeppelin-contracts
        branch = release-v4.9
[submodule "packages/contracts/lib/forge-std"]
	path = packages/contracts/lib/forge-std
	url = https://github.com/foundry-rs/forge-std
	branch = v1

Questions:

Is the above example correct?
This way we will no more have the ability to use forge update but use only git submodule update --remote, right? (in this case it would be nice to have a separate script in package.json like forge:update that uses git submodule update --remote under the hood)

Also some dependencies may be broken after such an update so perhaps this task also requires some refactoring.

Overall the issue looks good.

eugenioclrc · 2023-05-19T13:03:11Z

@eugenioclrc

So in the end in git submodules we will have smth similar to:
[submodule "packages/contracts/lib/openzeppelin-contracts"]
	path = packages/contracts/lib/openzeppelin-contracts
	url = https://github.com/OpenZeppelin/openzeppelin-contracts
        branch = release-v4.9
[submodule "packages/contracts/lib/forge-std"]
	path = packages/contracts/lib/forge-std
	url = https://github.com/foundry-rs/forge-std
	branch = v1
Questions:

Is the above example correct?

This way we will no more have the ability to use forge update but use only git submodule update --remote, right? (in this case it would be nice to have a separate script in package.json like forge:update that uses git submodule update --remote under the hood)

Also some dependencies may be broken after such an update so perhaps this task also requires some refactoring.

Overall the issue looks good.

Yes, you are correct
i think that instead of forge update a simple forge install should be enough, and if you want to update the lib you just change the branch, another suggestion could be using package.json to handle the libraries. This is an example of a project using that config; package.json#L25-L31

rndquu · 2023-05-19T13:19:34Z

another suggestion could be using package.json to handle the libraries

I think setting branch name in git submodules should be enough at the current project stage.

Migrating to package.json has some drawbacks:

Not a "native" way to install dependencies in foundry framework
New devs who come to the project would expect dependencies in the lib folder (because this is a foundry project)
Something should definitely be broken (some CI actions or scripts) if we remove the lib folder with git submodules

PhantomCracker · 2023-05-28T08:17:54Z

/start

PhantomCracker · 2023-05-28T08:46:08Z

Assign does not work anymore? Or it is because another PR was merged? (from what i have checked, the other PR does not solve this issue)

ubiquibot · 2023-05-28T09:13:00Z

Skipping /start since the issue is closed

0x4007 · 2023-05-28T09:13:34Z

We just pushed a big update to the bot and there are some big stability issues at the moment - sorry about that @PhantomCracker.

@0xcodercrane

0xcodercrane · 2023-05-29T03:34:22Z

big apologize here @PhantomCracker

PhantomCracker · 2023-05-29T06:59:14Z

big apologize here @PhantomCracker

No worries 👍

#643 - Solidity imported libraries should have a tagged version

ubiquibot · 2023-05-31T02:05:45Z

[ CLAIM 50 DAI ]

0xCAC0A8c...9AF40A6

rndquu · 2023-06-02T09:14:03Z

@PhantomCracker hi, I'm trying to reproduce the update to specific lib versions and it seems that git submodule update --init --remote updates only to the latest lib version ignoring any git submodule tags

So here is a list of improvements:

Git submodule tags do not a affect the updated lib version. We should use an exact branch name instead
We keep using the old libs here. This task implied all dependencies to be updated to the latest version.

Could you fix those issues?

PhantomCracker · 2023-06-02T11:26:07Z

@rndquu I made this commit for this pull request, can you please check it?
d554cbd
Also, if we include both branch and tags, tags have priority over branches

ghost · 2023-06-19T14:12:01Z

/start

ubiquibot · 2023-06-19T14:12:08Z

Skipping /start since the issue is closed

ghost · 2023-06-19T14:13:16Z

/start

ubiquibot · 2023-06-19T14:13:20Z

Skipping /start since the issue is closed

eugenioclrc · 2023-06-19T14:47:51Z

/start

ubiquibot · 2023-06-19T14:47:55Z

Skipping /start since the issue is closed

0x4007 · 2023-06-19T15:46:23Z

Looks like a few hunters are trying to hunt this bounty. @rndquu can you take this reviewing over and make sure thats its handled correctly?

ubiquibot · 2023-06-26T10:14:23Z

[ CLAIM 200 WXDAI ]

0x2bBc6a83...b75E3708c

0x4007 · 2023-06-26T10:19:17Z

Looks like a few hunters are trying to hunt this bounty. @rndquu can you take this reviewing over and make sure thats its handled correctly?

Congratulations @AnakinSkywalkeer you prevailed as the strongest hunter.

0x4007 · 2023-06-26T10:20:43Z

@0xcodercrane it looks like we generated two payment permits for this issue. Shouldn't this not be possible?

ghost · 2023-06-26T10:52:50Z

Looks like a few hunters are trying to hunt this bounty. @rndquu can you take this reviewing over and make sure thats its handled correctly?

Congratulations @AnakinSkywalkeer you prevailed as the strongest hunter.

Cool! :)

ghost · 2023-06-26T11:19:25Z

[ CLAIM 200 WXDAI ]

0x2bBc6a83...b75E3708c

@pavlovcik hey can u help me with this like i conected my metamask then i clicked claim it gave me
"PERMIT ALREADY CLAIMED" but i didn't receive 🤔

rndquu · 2023-06-26T12:32:05Z

[ CLAIM 200 WXDAI ]

0x2bBc6a83...b75E3708c

@pavlovcik hey can u help me with this like i conected my metamask then i clicked claim it gave me "PERMIT ALREADY CLAIMED" but i didn't receive 🤔

What happened:

Originally @PhantomCracker solved the current issue
Permit was generated
Then the issue was opened again because of the errors
@AnakinSkywalkeer solved the issue correctly
New permit was generated

Permits from step 2 and 5 have the same nonce. Permit from step 2 has already been claimed so permit from step 5 is invalid.

@pavlovcik help

ghost · 2023-06-26T12:42:03Z

[ CLAIM 200 WXDAI ]

0x2bBc6a83...b75E3708c

@pavlovcik hey can u help me with this like i conected my metamask then i clicked claim it gave me "PERMIT ALREADY CLAIMED" but i didn't receive 🤔

What happened:

Originally @PhantomCracker solved the current issue

Permit was generated

Then the issue was opened again because of the errors

@AnakinSkywalkeer solved the issue correctly

New permit was generated

Permits from step 2 and 5 have the same nonce. Permit from step 2 has already been claimed so permit from step 5 is invalid.

@pavlovcik help

ohhh

PhantomCracker · 2023-06-26T17:57:49Z

Maybe we need to create a new issue every time an error occurs instead of reopen the old ones?

P.S: Good job @AnakinSkywalkeer

0x4007 · 2023-06-26T18:06:52Z

Maybe we need to create a new issue every time an error occurs instead of reopen the old ones?

This was not implemented correctly the first time around so it should not have been accepted and paid out.

@AnakinSkywalkeer 0x2bBc6a8314044d70684C74CfA0E117eb75E3708c can you verify that this is your address?

ghost · 2023-06-26T18:21:00Z

Maybe we need to create a new issue every time an error occurs instead of reopen the old ones?

This was not implemented correctly the first time around so it should not have been accepted and paid out.

@AnakinSkywalkeer 0x2bBc6a8314044d70684C74CfA0E117eb75E3708c can you verify that this is your address?

yes its my address 0x2bBc6a8314044d70684C74CfA0E117eb75E3708c

0x4007 · 2023-06-26T18:39:12Z

[ CLAIM 200 WXDAI ]

0x2bBc6a83...b75E3708c

@pavlovcik hey can u help me with this like i conected my metamask then i clicked claim it gave me "PERMIT ALREADY CLAIMED" but i didn't receive 🤔

What happened:

Originally @PhantomCracker solved the current issue

Permit was generated

Then the issue was opened again because of the errors

@AnakinSkywalkeer solved the issue correctly

New permit was generated

Permits from step 2 and 5 have the same nonce. Permit from step 2 has already been claimed so permit from step 5 is invalid.

@pavlovcik help

@rndquu shouldn't it show "permit already claimed" as soon as the page loads? I remember seeing claimed permits being recognized with no user interaction on the dApp.

0x4007 · 2023-06-26T18:40:34Z

https://gnosisscan.io/tx/0xb0ff172f5af182942f0bad6e96fec98595eabfbccb7c356e674fe503908fc041 @AnakinSkywalkeer

eugenioclrc · 2023-06-27T01:17:49Z

Gnosis?? Cool!!! El lun, 26 de jun de 2023, 15:40, アレクサンダー.eth ***@***.***> escribió:

…

https://gnosisscan.io/tx/0xb0ff172f5af182942f0bad6e96fec98595eabfbccb7c356e674fe503908fc041 @AnakinSkywalkeer <https://github.com/AnakinSkywalkeer> — Reply to this email directly, view it on GitHub <#643 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACRFCTVZS46K4DH2EKX4N3XNHJS3ANCNFSM6AAAAAAYFZTBVI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

ghost · 2023-06-27T05:23:57Z

https://gnosisscan.io/tx/0xb0ff172f5af182942f0bad6e96fec98595eabfbccb7c356e674fe503908fc041 @AnakinSkywalkeer

Thanks!! I received it

0x4007 · 2023-06-30T09:41:09Z

[ CLAIM 200 WXDAI ]

0x2bBc6a83...b75E3708c

Invalidated https://gnosisscan.io/tx/0xe8ca542d6e4fe579ccc8f04f12179476989f58d85b162aa863a36719f73de232

ubiquibot bot mentioned this issue May 18, 2023

Solidity imported libraries should have a version ubiquity/devpool-directory#614

Closed

0x4007 added the Priority: 1 (Medium) label May 18, 2023

ubiquibot bot added the Price: 200+ USD label May 18, 2023

0x4007 added Time: <1 Hour and removed Price: 200+ USD labels May 18, 2023

ubiquibot bot added the Price: 50 USD label May 18, 2023

This was referenced May 18, 2023

Refactor to ERC20Ubiquity #644

Closed

fix git submodules #624

Closed

rndquu mentioned this issue May 25, 2023

Refactor erc20 ubiquity #649

Merged

rndquu added the good first issue label May 26, 2023

0x4007 assigned PhantomCracker May 28, 2023

PhantomCracker mentioned this issue May 28, 2023

#643 - Solidity imported libraries should have a tagged version #661

Merged

0x4007 closed this as completed in #661 May 31, 2023

0x4007 added a commit that referenced this issue May 31, 2023

Merge pull request #661 from PhantomCracker/development

3935730

#643 - Solidity imported libraries should have a tagged version

ubiquibot bot added the Permitted label May 31, 2023

rndquu reopened this Jun 2, 2023

rndquu removed the Price: 400 USD label Jun 19, 2023

rndquu changed the title ~~Solidity imported libraries should have a tagged version~~ Solidity imported libraries should have a version Jun 19, 2023

ubiquibot bot assigned ghost Jun 19, 2023

ghost mentioned this issue Jun 19, 2023

fix: removed the tags and added the branch in .gitmodules #687

Merged

rndquu closed this as completed in #687 Jun 26, 2023

ubiquibot bot added the Permitted label Jun 26, 2023

rndquu mentioned this issue Jun 27, 2023

Penalty for reopened issues ubiquity/ubiquibot#439

Closed

rndquu mentioned this issue Jun 30, 2023

Fix multiple permit generation ubiquity/ubiquibot#446

Closed

Solidity imported libraries should have a version #643

Solidity imported libraries should have a version #643

Comments

eugenioclrc commented May 18, 2023 • edited by rndquu Loading

0x4007 commented May 18, 2023

eugenioclrc commented May 18, 2023

rndquu commented May 19, 2023

eugenioclrc commented May 19, 2023

rndquu commented May 19, 2023

PhantomCracker commented May 28, 2023 • edited by 0x4007 Loading

PhantomCracker commented May 28, 2023

ubiquibot bot commented May 28, 2023 • edited Loading

0x4007 commented May 28, 2023

0xcodercrane commented May 29, 2023

PhantomCracker commented May 29, 2023

ubiquibot bot commented May 31, 2023

[ CLAIM 50 DAI ]

rndquu commented Jun 2, 2023

PhantomCracker commented Jun 2, 2023

ghost commented Jun 19, 2023 • edited by 0x4007 Loading

ubiquibot bot commented Jun 19, 2023 • edited Loading

ghost commented Jun 19, 2023 • edited by 0x4007 Loading

ubiquibot bot commented Jun 19, 2023 • edited Loading

eugenioclrc commented Jun 19, 2023 • edited by 0x4007 Loading

ubiquibot bot commented Jun 19, 2023 • edited Loading

0x4007 commented Jun 19, 2023 • edited Loading

ubiquibot bot commented Jun 26, 2023

[ CLAIM 200 WXDAI ]

0x4007 commented Jun 26, 2023

0x4007 commented Jun 26, 2023

ghost commented Jun 26, 2023

ghost commented Jun 26, 2023

[ CLAIM 200 WXDAI ]

rndquu commented Jun 26, 2023

[ CLAIM 200 WXDAI ]

ghost commented Jun 26, 2023

[ CLAIM 200 WXDAI ]

PhantomCracker commented Jun 26, 2023

0x4007 commented Jun 26, 2023 • edited Loading

ghost commented Jun 26, 2023

0x4007 commented Jun 26, 2023

[ CLAIM 200 WXDAI ]

0x4007 commented Jun 26, 2023

eugenioclrc commented Jun 27, 2023 via email

ghost commented Jun 27, 2023

0x4007 commented Jun 30, 2023

[ CLAIM 200 WXDAI ]

eugenioclrc commented May 18, 2023 •

edited by rndquu

Loading

PhantomCracker commented May 28, 2023 •

edited by 0x4007

Loading

ubiquibot bot commented May 28, 2023 •

edited

Loading

ghost commented Jun 19, 2023 •

edited by 0x4007

Loading

ubiquibot bot commented Jun 19, 2023 •

edited

Loading

ghost commented Jun 19, 2023 •

edited by 0x4007

Loading

ubiquibot bot commented Jun 19, 2023 •

edited

Loading

eugenioclrc commented Jun 19, 2023 •

edited by 0x4007

Loading

ubiquibot bot commented Jun 19, 2023 •

edited

Loading

0x4007 commented Jun 19, 2023 •

edited

Loading

0x4007 commented Jun 26, 2023 •

edited

Loading