check that diamond storage is untouched after each pr #636

zgorizzo69 · 2023-05-12T18:14:17Z

best would be to add a gh action to make sure that we haven't messed with the diamond storage

PhantomCracker · 2023-05-28T18:34:41Z

/start

ubiquibot · 2023-05-28T18:34:46Z

Skipping /start since the issue is already assigned

PhantomCracker · 2023-05-30T17:10:13Z

Hello @zgorizzo69 ,
Can you help with something? I have 2 questions:

where can i find the diamond storage?
is there a backup for diamond storage?

I am thinking of checking the diamond storage before creating a PR and after

ubiquibot · 2023-06-03T23:47:18Z

Do you have any updates @PhantomCracker? If you would like to release the bounty back to the DevPool, please comment /unassign

PhantomCracker · 2023-06-04T07:18:19Z

This is work in progress

0x4007 · 2023-06-04T11:18:09Z

Hello @zgorizzo69 , Can you help with something? I have 2 questions:

where can i find the diamond storage?

is there a backup for diamond storage?

I am thinking of checking the diamond storage before creating a PR and after

Perhaps @rndquu might be able to help with this question.

PhantomCracker · 2023-06-05T08:50:02Z

Hello @zgorizzo69 , Can you help with something? I have 2 questions:

where can i find the diamond storage?

is there a backup for diamond storage?

I am thinking of checking the diamond storage before creating a PR and after

Perhaps @rndquu might be able to help with this question.

I did it in another way so we are good now, thank you!

0x4007 · 2023-06-08T02:28:07Z

I just realized that a week to create a single .yml file seems very steep.

I will need to lower the time estimate to a day if the current assignee is unable to complete.

PhantomCracker · 2023-06-08T09:35:09Z

I will try to finish as fast as possible.

PhantomCracker · 2023-06-08T20:32:09Z

Need to test a few more things here and I will come back with updated PR

Arjuna2022 · 2023-06-15T15:57:54Z

name: Check Diamond Storage
on:
pull_request:
branches:
- main
jobs:
check_diamond_storage:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Check Diamond Storage Hash
run: |
echo "Checking diamond storage hash..."
before_hash=$(sha256sum diamond_storage)
git merge --no-ff main
after_hash=$(sha256sum diamond_storage)
if [ "$before_hash" != "$after_hash" ]; then
echo "Diamond storage has been tampered with!"
else
echo "Diamond storage has not been tampered with."
fi
Hello everyone, i was wondering if this code helps i got here from build box. very inexpericeind so any advice would be kind helpfull.

ubiquibot · 2023-06-15T15:57:56Z

Available commands

- /assign: Assign the origin sender to the issue automatically.
- /unassign: Unassign the origin sender from the issue automatically.
- /help: List all available commands.
- /payout: Disable automatic payment for the issue.
- /multiplier: Set bounty multiplier (for treasury)
- /allow: Set access control. (Admin Only)
- /wallet: <WALLET_ADDRESS | ENS_NAME>: Register the hunter's wallet address. 
  ex1: /wallet 0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266 
  ex2: /wallet vitalik.eth

@Arjuna2022

rndquu · 2023-06-15T16:12:46Z

name: Check Diamond Storage on: pull_request: branches: - main jobs: check_diamond_storage: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 - name: Check Diamond Storage Hash run: | echo "Checking diamond storage hash..." before_hash=$(sha256sum diamond_storage) git merge --no-ff main after_hash=$(sha256sum diamond_storage) if [ "$before_hash" != "$after_hash" ]; then echo "Diamond storage has been tampered with!" else echo "Diamond storage has not been tampered with." fi Hello everyone, i was wondering if this code helps i got here from build box. very inexpericeind so any advice would be kind helpfull.

this issue is already taken by the other bounty hunter, pls find an issue with no assignee

0x4007 · 2023-06-15T19:56:12Z

name: Check Diamond Storage
on:
pull_request:
branches:

main
jobs:
check_diamond_storage:
runs-on: ubuntu-latest
steps:

uses: actions/checkout@v2

name: Check Diamond Storage Hash
run: |
echo "Checking diamond storage hash..."
before_hash=$(sha256sum diamond_storage)
git merge --no-ff main
after_hash=$(sha256sum diamond_storage)
if [ "$before_hash" != "$after_hash" ]; then
echo "Diamond storage has been tampered with!"
else
echo "Diamond storage has not been tampered with."
fi
Hello everyone, i was wondering if this code helps i got here from build box. very inexpericeind so any advice would be kind helpfull.

I think that a fully GitHub Action implementation makes a lot more sense actually vs what we have going on in the associated pull request. I'm just unsure if it makes sense to throw an error on CI if changes happen. I don't think the pull request reviewers should be expected to manually check the CI logs every time before merging.

PhantomCracker · 2023-06-16T06:57:46Z

Hei @pavlovcik,
I can throw an error if changes happen if this is required.
Regarding github action or script, it will be a long action if we write everything there and it will be harder to read.
Like this, we use best practices for this type of issue/feature.

0x4007 · 2023-06-18T13:08:08Z

It might be best to post a comment in the pull request so that we don't need to dig through the CI logs, similar to what we do already for the deployments.

rndquu · 2023-07-04T10:10:29Z

This issue is really tricky

We have a diamond contract which includes all the facets.

Each facet has a struct (example) which is used as a storage in a unique slot (example).

So on each PR we should check that:

state variables in storage structs are not modified
now new state variables are added in the beginning or middle of storage structs (we can add new state variables only to the end of a storage struct in order not to allow a storage collision)
check that the same rules are also applied to the AppStorage (which occupies slot 0 in all of the facets)
make sure that newly added facets are also checked accordingly

So there should be a script that fetches storage layouts from all of the facets (perhaps via forge inspect) and compares the structure in the PR with the structure in the development branch

ubiquibot · 2023-07-13T07:55:59Z

Releasing the bounty back to dev pool because the allocated duration already ended!
Last activity time: Fri Jun 16 2023 06:57:46 GMT+0000 (Coordinated Universal Time)

PhantomCracker · 2023-07-13T08:00:27Z

/start

Resolves: #636

gitcoindev/foundry-storage-check fork Use foundry-storage-check fork with diamond storage support. Resolves: #636

…nges As requested during pr review. Resolves: #636

…hanges As requested during pr review. Resolves: #636

As discussed during PR review. Resolves: #636

…rary search Treat each input as a NAME, use basename -a option instead of -s. Testing detected that using -s option lost LibAccessControl library. Resolves: #636

As discussed during PR review. Resolves: #636

Resolves: #636

…check Resolves: #636

Use the same solution that was implemented for core contracts. Resolves: #636

gitcoindev · 2023-09-28T07:55:00Z

Thanks @rndquu @molecula451 @pavlovcik this was a significant effort not only for me but also for you, checking, testing and commenting took a lot of time.

Now it seems that the bot was overwhelmed by all of this, seeing this number of comments and did not trigger any comment nor triggered any incentives . I hope we can get this fixed and make the bot generate all incentives correctly.

0x4007 · 2023-09-28T07:56:05Z

We are texting in the group chat about it now t.me/ubiquitydao

Please know that this is a priority for us to address this

We are scrambling for a fix now

Thanks for your contributions and your patience.

ubiquibot · 2023-09-28T10:07:01Z

Permit generation skipped because wallet private key is not set

If you enjoy the DevPool experience, please follow Ubiquity on GitHub and star this repo to show your support. It helps a lot!

ubiquibot · 2023-09-28T10:12:21Z

Task Assignee Reward

[ CLAIM 800 WXDAI ]

0x7e92476D...A5566653a

If you've enjoyed your experience in the DevPool, we'd appreciate your support. Follow Ubiquity on GitHub and star this repo. Your endorsement means the world to us and helps us grow!

We are excited to announce that the DevPool and UbiquiBot are now available to partners! Our ideal collaborators are globally distributed crypto-native organizations, who actively work on open source on GitHub, and excel in research & development. If you can introduce us to the repository maintainers in these types of companies, we have a special bonus in store for you!

ubiquibot · 2023-09-28T10:12:24Z

Task Creator Reward

zgorizzo69: [ CLAIM 5.7 WXDAI ]

gitcoindev · 2023-09-28T10:40:17Z

Thanks @rndquu ! I guess the same approach can be used with #775

molecula451 · 2023-09-28T10:51:41Z

also looks like it missed lot of the conversational rewars, looks like couldn't handle many commenting?. Would be nice see it re-triggered @rndquu

PhantomCracker · 2023-09-28T17:16:01Z

Congratulations @gitcoindev for finishing this issue! Pretty hard one :)

rndquu · 2023-09-29T06:55:06Z

also looks like it missed lot of the conversational rewars, looks like couldn't handle many commenting?. Would be nice see it re-triggered @rndquu

We will re-trigger when the bot is switched back to the main prod branch. Right now the bot's prod deployment is on a commit without proper conversation rewards.

molecula451 · 2023-10-05T08:33:01Z

@rndquu i think we should try to re-trigger conversational rewards here, i think the bot is reacting to those on your calls, there were helpful comment here to reach the goal (which after a couple of days) the PR was nice

rndquu · 2023-10-05T09:41:41Z

@rndquu i think we should try to re-trigger conversational rewards here, i think the bot is reacting to those on your calls, there were helpful comment here to reach the goal (which after a couple of days) the PR was nice

I don't really want to re-trigger anything because rewards generation is kind of unpredicted right now. Let's wait for a stable bot's release.

zgorizzo69 added the Time: <1 Week label May 12, 2023

ubiquibot bot added the Price: 200+ USD label May 12, 2023

ubiquibot bot mentioned this issue May 12, 2023

check that diamond storage is untouched after each pr ubiquity/devpool-directory#602

Closed

0x4007 added the Priority: 1 (Medium) label May 15, 2023

ubiquibot bot added Price: 800 USD and removed Price: 200+ USD labels May 15, 2023

ubiquibot bot assigned PhantomCracker May 28, 2023

PhantomCracker mentioned this issue Jun 4, 2023

636 - Check that diamond storage is untouched after each pull request #666

Closed

1337-ishaan mentioned this issue Jun 29, 2023

Detect diamond_storage #709

Closed

ubiquibot bot unassigned PhantomCracker Jul 13, 2023

ubiquibot bot assigned PhantomCracker Jul 13, 2023

molecula451 pushed a commit that referenced this issue Sep 28, 2023

chore: pr storage check

af106dd

Resolves: #636

molecula451 pushed a commit that referenced this issue Sep 28, 2023

chore: switch diamond storage pr check to

9bcb5eb

gitcoindev/foundry-storage-check fork Use foundry-storage-check fork with diamond storage support. Resolves: #636

molecula451 pushed a commit that referenced this issue Sep 28, 2023

chore: rename the GitHub action step to Check For Diamond Storage Cha…

0598f32

…nges As requested during pr review. Resolves: #636

molecula451 pushed a commit that referenced this issue Sep 28, 2023

chore: rename the GitHub workflow name to Check For Diamond Storage C…

be2e0b2

…hanges As requested during pr review. Resolves: #636

molecula451 pushed a commit that referenced this issue Sep 28, 2023

chore: remove DiamondInit and facets from diamond storage check

e959525

As discussed during PR review. Resolves: #636

molecula451 pushed a commit that referenced this issue Sep 28, 2023

chore: run storage check workflows only when *.sol files are updated

d9a36e5

As discussed during PR review. Resolves: #636

molecula451 pushed a commit that referenced this issue Sep 28, 2023

chore: add failOnRemoval true to diamond contracts storage changes check

4957de0

Resolves: #636

molecula451 pushed a commit that referenced this issue Sep 28, 2023

chore: add failOnLabelDiff true to diamond contracts storage changes …

eb5604d

…check Resolves: #636

molecula451 pushed a commit that referenced this issue Sep 28, 2023

chore: fix github action warning

9e781b7

Use the same solution that was implemented for core contracts. Resolves: #636

rndquu reopened this Sep 28, 2023

rndquu closed this as completed Sep 28, 2023

rndquu reopened this Sep 28, 2023

rndquu closed this as completed Sep 28, 2023

ubiquibot bot added the Permitted label Sep 28, 2023

ubiquity deleted a comment from ubiquibot bot Sep 28, 2023

rndquu reopened this Sep 28, 2023

rndquu closed this as completed Sep 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

check that diamond storage is untouched after each pr #636

check that diamond storage is untouched after each pr #636

zgorizzo69 commented May 12, 2023

PhantomCracker commented May 28, 2023 •

edited by 0x4007

Loading

ubiquibot bot commented May 28, 2023 •

edited

Loading

PhantomCracker commented May 30, 2023

ubiquibot bot commented Jun 3, 2023

PhantomCracker commented Jun 4, 2023

0x4007 commented Jun 4, 2023

PhantomCracker commented Jun 5, 2023

0x4007 commented Jun 8, 2023

PhantomCracker commented Jun 8, 2023 •

edited

Loading

PhantomCracker commented Jun 8, 2023

Arjuna2022 commented Jun 15, 2023

ubiquibot bot commented Jun 15, 2023

rndquu commented Jun 15, 2023

0x4007 commented Jun 15, 2023 •

edited

Loading

PhantomCracker commented Jun 16, 2023

0x4007 commented Jun 18, 2023 •

edited

Loading

rndquu commented Jul 4, 2023

ubiquibot bot commented Jul 13, 2023

PhantomCracker commented Jul 13, 2023 •

edited by 0x4007

Loading

gitcoindev commented Sep 28, 2023

0x4007 commented Sep 28, 2023

ubiquibot bot commented Sep 28, 2023

ubiquibot bot commented Sep 28, 2023

ubiquibot bot commented Sep 28, 2023

gitcoindev commented Sep 28, 2023

molecula451 commented Sep 28, 2023 •

edited

Loading

PhantomCracker commented Sep 28, 2023

rndquu commented Sep 29, 2023

molecula451 commented Oct 5, 2023

rndquu commented Oct 5, 2023

check that diamond storage is untouched after each pr #636

check that diamond storage is untouched after each pr #636

Comments

zgorizzo69 commented May 12, 2023

PhantomCracker commented May 28, 2023 • edited by 0x4007 Loading

ubiquibot bot commented May 28, 2023 • edited Loading

PhantomCracker commented May 30, 2023

ubiquibot bot commented Jun 3, 2023

PhantomCracker commented Jun 4, 2023

0x4007 commented Jun 4, 2023

PhantomCracker commented Jun 5, 2023

0x4007 commented Jun 8, 2023

PhantomCracker commented Jun 8, 2023 • edited Loading

PhantomCracker commented Jun 8, 2023

Arjuna2022 commented Jun 15, 2023

ubiquibot bot commented Jun 15, 2023

Available commands

rndquu commented Jun 15, 2023

0x4007 commented Jun 15, 2023 • edited Loading

PhantomCracker commented Jun 16, 2023

0x4007 commented Jun 18, 2023 • edited Loading

rndquu commented Jul 4, 2023

ubiquibot bot commented Jul 13, 2023

PhantomCracker commented Jul 13, 2023 • edited by 0x4007 Loading

gitcoindev commented Sep 28, 2023

0x4007 commented Sep 28, 2023

ubiquibot bot commented Sep 28, 2023

If you enjoy the DevPool experience, please follow Ubiquity on GitHub and star this repo to show your support. It helps a lot!

ubiquibot bot commented Sep 28, 2023

Task Assignee Reward

[ CLAIM 800 WXDAI ]

If you've enjoyed your experience in the DevPool, we'd appreciate your support. Follow Ubiquity on GitHub and star this repo. Your endorsement means the world to us and helps us grow!

ubiquibot bot commented Sep 28, 2023

Task Creator Reward

zgorizzo69: [ CLAIM 5.7 WXDAI ]

gitcoindev commented Sep 28, 2023

molecula451 commented Sep 28, 2023 • edited Loading

PhantomCracker commented Sep 28, 2023

rndquu commented Sep 29, 2023

molecula451 commented Oct 5, 2023

rndquu commented Oct 5, 2023

PhantomCracker commented May 28, 2023 •

edited by 0x4007

Loading

ubiquibot bot commented May 28, 2023 •

edited

Loading

PhantomCracker commented Jun 8, 2023 •

edited

Loading

0x4007 commented Jun 15, 2023 •

edited

Loading

0x4007 commented Jun 18, 2023 •

edited

Loading

PhantomCracker commented Jul 13, 2023 •

edited by 0x4007

Loading

molecula451 commented Sep 28, 2023 •

edited

Loading