fix: close pr issues and stop running handlers twice

[seprintour]

Resolves #710 and #716

QA: Seprintour-Test/test#22

Steps:

• closePullRequestForAnIssue was called twice, i removed it from the unassign function so unassigning is now certain (no blocking request, closing PRs by looping was pretty intensive)

• Refactored closePullRequestForAnIssue to use the gitIssueParser to fetch the exact PR open for an issue instead of looping all PRs. (Closing is more certain and 1 memory intensive task down)

[netlify]

✅ Deploy Preview for ubiquibot-staging ready!

Name	Link
🔨 Latest commit	c6ce0ea
🔍 Latest deploy log	https://app.netlify.com/sites/ubiquibot-staging/deploys/6508a934b71b6400087abd5d
😎 Deploy Preview	https://deploy-preview-728--ubiquibot-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[seprintour]

@rndquu @whilefoo

[seprintour]

Update here?

[whilefoo]

can you rework gitLinkedPrParser to return an array of PRs and move other functionality (like retrieving PR and checking merged date to get latest merged PR) outside the function. basically you are merging your work into gitLinkedPrParser and then removing gitIssueParser

[seprintour]

can you rework gitLinkedPrParser to return an array of PRs and move other functionality (like retrieving PR and checking merged date to get latest merged PR) outside the function. basically you are merging your work into gitLinkedPrParser and then removing gitIssueParser

I don't understand what you mean by get it outside the function

[whilefoo]

functions calling gitLinkedPrParser can make additional transformations and gitLinkedPrParser should only be focused on returning array of PRs to make it generic as possible

[seprintour]

functions calling gitLinkedPrParser can make additional transformations and gitLinkedPrParser should only be focused on returning array of PRs to make it generic as possible

Done, check it out @whilefoo

[whilefoo]

can you post QA?

[wannacfuture]

Looks good to me

[seprintour]

can you post QA?

I have QA in description

[seprintour]

@0xcodercrane ping