-
Notifications
You must be signed in to change notification settings - Fork 61
Config validation error #684
Config validation error #684
Conversation
✅ Deploy Preview for ubiquibot-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
First one is great. Second one is vague is there anything you can do to improve that type of message? |
I improved the message: |
It would be nice to get the name additional properties in console logs and supabase logs.
The bot didn't add comment here on wrong config. I have only
|
Added
This happened because the config on development was invalid, so you pushed the change, the bot tried to load the current config but it's invalid so it stops. I modified the code to run validateConfigChange even if config load fails. |
It looks like you should merge the |
Resolves #680
Example:
ubiquity-whilefoo@b74601f#comments
ubiquity-whilefoo@c8e02c0#comments
It was kinda hard to log config errors because if the config was invalid, I also didn't have Supabase keys which the logger needs to write logs to database, so I had to write additional fallbacks