improve codebase: add unit testing #514
Conversation
✅ Deploy Preview for ubiquibot-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
This seems like a pretty solid start. Thanks for your high quality first time contribution to this repository @molecula451 !
There was a problem hiding this comment.
I reviewed my specification and I still think we should consider setting up a GitHub Actions Docker runtime. I haven't done a deep dive on researching these matters so I'm not 100% confident on the best way forward. The business problem I am aiming to solve is to minimize or eliminate the reliance on our manual quality assurance processes.
The worst is when pull requests pass reviews, and then bugs appear in staging/production.
@rndquu @molecula451 curious on your input here.
We plan to go step by step:
|
CI already working and testing on https://github.com/ubiquity/ubiquibot/actions/runs/5574793016/jobs/10183863908 Adding and polishing more tests |
and I am in pair with that vision, but a reminder that's why you have @rndquu and I for the good QA and making sure things work as of highest standard |
| describe("Help", () => { | ||
| it("should generate log menu", () => { | ||
| const helpMenu = generateHelpMenu(); | ||
| expect(helpMenu).toBeTruthy(); |
There was a problem hiding this comment.
this truthy it's better on this one as generateHelpMenu() output is prone to change
|
Stale |
|
@pavlovcik this was not at all stale thing is rndquu changed the game of the original description which was to create an initial base for unit testing ive opened the PR before the asked changed. That i stale a bit. But then i reincorporate and i was desigining a Payload mock testing for the commands this is not trivial and was taking time |
|
The last update on this was 19 days ago. It doesn't look like it's being worked on anymore which is why I closed it. |
Resolves #176