-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parameter descriptions for core plugins in the plugin-input.ts
#24
Comments
@gentlementlegen Pls check the description. Perhaps there's a way to create plugin parameter configuration descriptions in the plugin-input.ts file. |
@rndquu I believe there is a simpler way. For every item in the configuration, there is a "description" parameter available. It gets serialized in the manifest.json and is available right away. Example: The following code Yields the following configuration And I think this would be usable by the UI |
Awesome, thanks, updated the spec |
manifest.json
plugin-input.ts
I think we should also support injecting the plugin url into the manifest after worker deployment too (could do the same for action plugins too)
|
@gentlementlegen I'm comfortable doing this for all plugins with the exception of https://github.com/ubiquity-os-marketplace/text-conversation-rewards/blob/development/src/types/plugin-input.ts, would you mind doing this one and I'll catch the rest? I can see there is We have the README displayed to the right of the editor now. So for each input should we have a little tooltip info indicator top-right adjacent to the input title i.e |
I think tooltip is fine |
|
/start |
Thanks @gentlementlegen for handling that one for me, appreciate it |
/start |
A new workroom has been created for this task. Join chat |
Cheers @gentlementlegen I've mocked the descriptions in the linked PR for now and once the related PRs in plugin repos are merged I'll replace the mocks. |
/start |
! This issue is already assigned. Please choose another unassigned task. |
Passed the deadline and no activity is detected, removing assignees: @Keyrxng. |
@Keyrxng the deadline is at Wed, Dec 4, 11:35 AM UTC |
Passed the deadline and no activity is detected, removing assignees: @Keyrxng. |
@Keyrxng the deadline is at Tue, Dec 10, 12:39 AM UTC |
Passed the disqualification threshold and no activity is detected, removing assignees: @Keyrxng. |
/help |
Available Commands
|
/start |
Tip
|
Right now all core plugins have a
manifest.json
file (example) describing plugin's:The issue is that when plugin configuration is displayed in https://github.com/ubiquity-os/ubiquity-os-plugin-installer there're no any configuration parameter descriptions so it's really hard for a partner to find out what parameters are meant to be used for:
What should be done for all of the core plugins in https://github.com/ubiquity-os-marketplace:
name
property in themanifest.json
(some of the core plugins miss it)description
property in themanifest.json
plugin-input.ts
file (for example this code generates this manifest). Simply put we should add thedescription
field for all of the plugin parameters in theplugin-input.ts
file. Description should include general info and possible parameter options.Notice that in the
manifest.json
file theconfiguration
schema is created dynamically:Then we'll display all configuration parameter descriptions in https://github.com/ubiquity-os/ubiquity-os-plugin-installer on creating/editing a config.
Update: parameter description PRs:
The text was updated successfully, but these errors were encountered: