Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add token fallback, add debug log #23

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

Keyrxng
Copy link
Collaborator

@Keyrxng Keyrxng commented Oct 29, 2024

  • TEMP_SAFE_PAT used as a octokit auth fallback
  • the PAT is my alt account I use for QA
  • It's temp until the core issue is resolved

@Keyrxng Keyrxng merged commit 103bd38 into ubiquity-os-marketplace:development Oct 29, 2024
1 of 2 checks passed
@Keyrxng
Copy link
Collaborator Author

Keyrxng commented Oct 29, 2024

@gentlementlegen @0x4007

"Error: [universal-github-app-jwt] Private Key is in PKCS#1 format, but only PKCS#8 is supported. See https://github.com/gr2m/universal-github-app-jwt#private-key-formats"

Realized we need to String(error) if it's an Error to read it, the reason our error prop has been empty I reckon.

The private key is being uploaded directly from the org secrets so it must have been saved in the wrong format?

@Keyrxng
Copy link
Collaborator Author

Keyrxng commented Oct 29, 2024

@Keyrxng, this task has been idle for a while. Please provide an update.

@Keyrxng
Copy link
Collaborator Author

Keyrxng commented Oct 29, 2024

TEMP_SAFE_PAT can be removed once the secret upload is resolved. I don't have access to be able to fix it.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant