Merge pull request #51 from EdwinVanVliet/main

Fix for reading TXT Records.
ubiety · May 18, 2024 · 9c02d74 · 9c02d74
2 parents 6c70c2c + 543cee0
commit 9c02d74
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 14 deletions.
diff --git a/src/Ubiety.Dns.Core/Common/Extensions/EnumExtensions.cs b/src/Ubiety.Dns.Core/Common/Extensions/EnumExtensions.cs
@@ -31,18 +31,12 @@ public static class EnumExtensions
         /// </summary>
         /// <param name="type">Type of record to get.</param>
         /// <param name="reader">Resource reader to create record with.</param>
-        /// <param name="length">Length of the record.</param>
         /// <returns>A <see cref="Record"/> instance for the given type.</returns>
-        public static Record GetRecord(this RecordType type, RecordReader reader, int length = 0)
+        public static Record GetRecord(this RecordType type, RecordReader reader)
         {
             var fieldInfo = type.GetType().GetField(type.ToString());
             var recordAttr = fieldInfo.GetCustomAttribute<RecordAttribute>();
 
-            if (type == RecordType.TXT)
-            {
-                return (Record)Activator.CreateInstance(recordAttr.RecordType, reader, length);
-            }
-
             return (Record)Activator.CreateInstance(recordAttr.RecordType, reader);
         }
     }

diff --git a/src/Ubiety.Dns.Core/Records/RecordTxt.cs b/src/Ubiety.Dns.Core/Records/RecordTxt.cs
@@ -45,16 +45,13 @@ public record RecordTxt : Record
         ///     Initializes a new instance of the <see cref="RecordTxt" /> class.
         /// </summary>
         /// <param name="reader"><see cref="RecordReader" /> for the record data.</param>
-        /// <param name="length">Record length.</param>
-        public RecordTxt(RecordReader reader, int length)
+        public RecordTxt(RecordReader reader)
             : base(reader)
         {
-            var position = Reader.Position;
-            Text = new List<string>();
-            while ((Reader.Position - position) < length)
+            Text = new List<string>
             {
-                Text.Add(Reader.ReadString());
-            }
+                Reader.ReadString()
+            };
         }
 
         /// <summary>