Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of some translations in 5.1.0 #250

Open
rafsaf opened this issue Dec 15, 2024 · 1 comment
Open

Lack of some translations in 5.1.0 #250

rafsaf opened this issue Dec 15, 2024 · 1 comment

Comments

@rafsaf
Copy link

rafsaf commented Dec 15, 2024

Hi!

Currently in 5.1.0 in new django_registration/activation_form.html after #247 there are some translations missing, for example:

image

At first glance:

EXPIRED_MESSAGE = _("This account has expired.")
INVALID_KEY_MESSAGE = _("The activation key you provided is invalid.")
activation_key = forms.CharField()

I think this activation_key needs "label" label=_("Activation key") and beside that some "makemessages", "compilemessages" commands are needed because both error messages don't appear in any .po files. I can craft some PR in spare time.

But there are quite many languages supported here so maybe instead of bump each of them by individual developers (which looks to be the case in the past when i look on code base) maybe some more general solution is possible (AI generated translation or something, there are quite good nowadays).

BR

@ubernostrum
Copy link
Owner

To be honest, I never really touch the translation files. I can add the translation marker for the field label, but anything missing from the files themselves will need to be fixed by someone who knows what they're doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants