Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalised zhang li #75

Merged
merged 11 commits into from
Jul 22, 2024
Merged

Generalised zhang li #75

merged 11 commits into from
Jul 22, 2024

Conversation

lang-m
Copy link
Member

@lang-m lang-m commented Jul 13, 2023

Support for current in arbitrary direction.

The typesystem code does the job but is not so elegant. We may want to rewrite this long term.

  • The changes broke support for subregion dictionaries
  • Update tests to allow vector-valued u

@lang-m lang-m requested a review from swapneelap July 14, 2023 08:08
Copy link
Member

@swapneelap swapneelap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

micromagneticmodel/dynamics/zhangli.py Outdated Show resolved Hide resolved
micromagneticmodel/dynamics/zhangli.py Outdated Show resolved Hide resolved
micromagneticmodel/dynamics/zhangli.py Outdated Show resolved Hide resolved
micromagneticmodel/dynamics/zhangli.py Outdated Show resolved Hide resolved
@lang-m lang-m requested a review from samjrholt June 9, 2024 15:03
@lang-m lang-m requested a review from samjrholt July 14, 2024 12:33
@lang-m lang-m merged commit 3fe9cff into master Jul 22, 2024
7 checks passed
@lang-m lang-m deleted the generalised-zhang-li branch July 22, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants