Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RideParametersBuilder #182

Merged
merged 3 commits into from
Sep 15, 2017
Merged

Add RideParametersBuilder #182

merged 3 commits into from
Sep 15, 2017

Conversation

edjiang
Copy link
Contributor

@edjiang edjiang commented Sep 14, 2017

Addresses feedback in #177.

@edjiang edjiang requested a review from bobz September 14, 2017 03:53
bobz
bobz approved these changes Sep 14, 2017
View reviewed changes
Copy link

@bobz bobz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having the constructor know about the Builder seems unidiomatic and creates an unnecessary circular dependency. My instinct would be to use a more traditional constructor here.

But your call.

@edjiang edjiang changed the base branch from swift-4-migration-pt-3 to develop September 14, 2017 23:03
@edjiang
Copy link
Contributor Author

edjiang commented Sep 14, 2017

Sounds great, addressed!

@edjiang
Copy link
Contributor Author

edjiang commented Sep 14, 2017

Needed to actually un-nest the builder because nested objects don't import very well in Objective-C

https://bugs.swift.org/browse/SR-2267

@edjiang edjiang merged commit 3be952f into develop Sep 15, 2017
@edjiang edjiang deleted the rideparams-builder branch September 15, 2017 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobz bobz bobz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edjiang @bobz