Swifty APIs (Pt 2) #177
Merged
Swifty APIs (Pt 2) #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobz
suggested changes
Sep 7, 2017
bobz
approved these changes
Sep 7, 2017
|
Conditional approval, but let's go back and add immutability with a simplified builder. |
edjiang
force-pushed
the
swifty-apis
branch
from
a330fe8 to
8d98899
Compare
edjiang
added a commit
that referenced
this pull request
Sep 14, 2017
edjiang
added a commit
that referenced
this pull request
Sep 14, 2017
edjiang
added a commit
that referenced
this pull request
Sep 15, 2017
edjiang
added a commit
that referenced
this pull request
Sep 15, 2017
* Make RideParameters immutable and add builder to mutate, addressing feedback in #177 * Remove circular dependency in builder * Un-nest RideParametersBuilder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce complexity of the
RideParametersmodel by removing the builder associated with it.RideParametersrepresents the set of parameters sent via a deeplink, ride request widget, or the ride estimate/request API endpoints.In the previous implementation, the primary thing the builder added was to ensure that the
RideParameterswere immutable. However, I don't think there is a huge issue around mutability with this model, and the builder pattern is not super common in Swift anyways.