Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bar width (percentage) a prop for Bar Series #1018

Merged
merged 2 commits into from
Oct 22, 2018

Conversation

manassra
Copy link
Contributor

Make the bar width percentage, which was hardcoded to 85% by default, a prop that is passed to the BarSeries class.

@manassra manassra requested a review from jckr October 22, 2018 21:42
@benshope benshope self-requested a review October 22, 2018 22:28
Copy link
Contributor

@benshope benshope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@manassra manassra merged commit 055cead into master Oct 22, 2018
ayarcohaila pushed a commit to ayarcohaila/react-vis that referenced this pull request Jun 30, 2021
* Make bar width (percentage) a prop for Bar Series

* Update docs
ayarcohaila added a commit to ayarcohaila/react-vis that referenced this pull request May 30, 2023
* Make bar width (percentage) a prop for Bar Series

* Update docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants