Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped up tree-sitter-swift dependency and resolved test failures #374

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

Satyam1749
Copy link
Collaborator

@Satyam1749 Satyam1749 commented Feb 16, 2023

A new version of tree-sitter-swift was released to resolve issues reported by us (issue-272, issue-271) .

The new version has an issue, which is critical for our usecase, So created a fork with fix and updated tree-sitter-swift dependency with the same.

Since the grammar for !abc has changed in new release, A seprate rule for !TestEnum.stale_flag.isEnabled is not required and this rule would be handled with !true and !false rules.

Copy link
Collaborator

@ketkarameya ketkarameya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add description for your PR

Cargo.toml Show resolved Hide resolved
@Satyam1749 Satyam1749 changed the title Changed swift parser for polyglot to manually created parser on forked repo Bumped up tree-sitter-swift dependency and resolved test failures Feb 21, 2023
@Satyam1749 Satyam1749 force-pushed the tree-dependency branch 4 times, most recently from 428b4c7 to 84535d8 Compare February 22, 2023 12:44
Copy link
Collaborator

@ketkarameya ketkarameya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Satyam1749 Satyam1749 merged commit 8edb8db into master Feb 23, 2023
@Satyam1749 Satyam1749 deleted the tree-dependency branch February 23, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants