-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support str
-like values for str_to_int
#408
Conversation
Nice! Can we bump it back to the failing state just to see the issue in CI? I might just need to make sure it is allowed to run. |
4520843
to
e40971e
Compare
@ajfriend Force-pushed to the commit at failing state. Waiting for approval to run tests. |
Hmmm. Not clear why coverage isn't working, especially since it seems to be working on #409 |
Seems like a known issue with codecov action and PRs from a fork ... |
OK. I think this is good to land, but it sounds like we need to figure out an alternative to codecov going forward: #393 |
Since
numpy>=2
(?),str
values are not nativestr
butnumpy.str_
.Without the explicit conversion to
str
, the test fails with: