Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle polygons with z-coordinate #371

Merged
merged 7 commits into from
May 19, 2024
Merged

Handle polygons with z-coordinate #371

merged 7 commits into from
May 19, 2024

Conversation

ajfriend
Copy link
Contributor

@ajfriend ajfriend commented May 18, 2024

Make it so that we drop the Z coordinate (if it is present) when translating from a __geo_interface__ object. LatLngPoly will still always expect just 2 coordinates in each point.

Closes #368

@ajfriend ajfriend marked this pull request as draft May 18, 2024 23:25
Copy link

codecov bot commented May 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f0fc6df) to head (4f6b651).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #371   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          319       326    +7     
=========================================
+ Hits           319       326    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ajfriend ajfriend marked this pull request as ready for review May 19, 2024 00:56
@ajfriend
Copy link
Contributor Author

FYI @fhk

@ajfriend ajfriend merged commit d1f84f5 into master May 19, 2024
47 checks passed
@ajfriend ajfriend deleted the aj/zcoord branch May 19, 2024 15:35
@ajfriend ajfriend mentioned this pull request May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to handle (multi)polygons with Z-coordinate
3 participants