Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace _out_unordered and _out_ordered with _out_collection #339

Merged
merged 18 commits into from
Mar 10, 2024

Conversation

ajfriend
Copy link
Contributor

@ajfriend ajfriend commented Jan 1, 2024

Change the APIs so that functions that would previously return sets of cells now return lists of cells.

@ajfriend ajfriend marked this pull request as draft January 2, 2024 00:17
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (158f52d) to head (734a098).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #339   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          324       319    -5     
=========================================
- Hits           324       319    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@isaacbrodsky isaacbrodsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to mention in the respective doc strings that the ordering is not guaranteed from these functions.

tests/polyfill/test_h3.py Outdated Show resolved Hide resolved
@ajfriend ajfriend marked this pull request as ready for review March 9, 2024 23:44
@ajfriend
Copy link
Contributor Author

You might want to mention in the respective doc strings that the ordering is not guaranteed from these functions.

Done

@ajfriend ajfriend merged commit e64ff67 into master Mar 10, 2024
36 checks passed
@ajfriend ajfriend deleted the aj/ordered branch March 10, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants